Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Option to Make Thumbnails Search by Label Before Filename #17235

Open
GoodLuckTrying opened this issue Dec 4, 2024 · 2 comments
Labels
feature request New enhancement to RetroArch.

Comments

@GoodLuckTrying
Copy link

GoodLuckTrying commented Dec 4, 2024

Originally, RetroArch would search for and display thumbnails based on the label first, and then, if a match was not found, it would search by filename. However, this behavior was changed to prioritize filename searching by default.

I would like to request an option to add a setting that allows thumbnails to be searched by label first, as it was before. This would be especially useful in scenarios where a game has been modded (Be it music, a recolor, a translation , etc.) but you also want it to use the same save file as the unmodded/original game (For which, the actual ROM filename would be the same). In such cases, the save file would still match due to the identical filenames, and the label becomes the distinguishing factor between the original and modded versions.

Allowing the label to take priority in the thumbnail search would make it much easier to differentiate these games by their respective thumbnails while using the same save file if desired. Please consider adding this option to enhance flexibility for users with modded games/romhacks.

@GoodLuckTrying GoodLuckTrying added the feature request New enhancement to RetroArch. label Dec 4, 2024
@i30817
Copy link
Contributor

i30817 commented Dec 12, 2024

If that behavior changed, it's a real bad idea, since several libretro thumbnails directories dont follow filenames standard since the dumping groups doesnt care to make the filename equal to the actual name or cant. Like MAME.

Typically you can get the real thumbs and names in mame by either scanning the zips with the auto scan or manual scan the zips again but with the MAME dat in the options to get the real name.

If the default was changed as above that would mean that MAME playlists simply wouldn't get the thumbnails without double the number of server queries at least (try the filename, fail, try the label, succeed).

Afaict, there was no work done to try to rename all the libretro thumbnails of these few sets where the game name doesn't match the filename after the transformation to make the thumbs in the server match. I also don't see any reason to change this, unless you want to enable users of the manual scanner to scan without the dat, a bad idea in itself, because the mame zip filenames are horrible.

@GoodLuckTrying
Copy link
Author

Yeah I don't know the reason why it was changed, but it was.

I think it might work differently for MAME though, as I didn't have issues getting thumbnails for MAME after creating my playlist with the dat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New enhancement to RetroArch.
Projects
None yet
Development

No branches or pull requests

2 participants