Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aws-lc-rs to 1.12.0, and aws-lc-sys to 0.24.0 #1426

Open
heitbaum opened this issue Dec 17, 2024 · 1 comment
Open

Update aws-lc-rs to 1.12.0, and aws-lc-sys to 0.24.0 #1426

heitbaum opened this issue Dec 17, 2024 · 1 comment
Labels

Comments

@heitbaum
Copy link

Description

Compile with aws-lc-rs to 1.10.0, and aws-lc-sys to 0.22.0 fails when using gcc-15. Please update the dependencies now that the build issue has been fixed upstream.

Version

What version(s) of librespot does this problem exist in? 0.6.0 and 755aa2e

How to reproduce

Steps to reproduce the behavior in librespot e.g.

  1. Compile using gcc-15

Log

Host (what you are running librespot on):

  • OS: [e.g. Linux] Linux
  • Platform: [e.g. RPi 3B+] 24.04 (with test gcc-15)

Additional context

Na

@photovoltex
Copy link
Member

As far as I know, we don't include this library directly and just as a sub-dependency of hyper-rustls (see here

hyper-rustls = { version = "0.27.2", default-features = false, features = ["aws-lc-rs", "http1", "logging", "tls12", "native-tokio", "http2"] }
).

hyper-rustls on the other hand also just includes it as a sub-dependency of rustls (see here https://github.com/rustls/hyper-rustls/blob/main/Cargo.toml#L33).

And rustls just recently updated their version of the library (see here rustls/rustls#2286).

So from what I see, we have to wait for a new release of rustls and hyper-rustls (which includes the updated rustls version.


If you need this update quickly you can use git repositories directly as rust dependency (see here https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#specifying-dependencies-from-git-repositories).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants