Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Adobe APP14 tag to JPEG images with specific colorspaces (fix XYB appearance in most apps) #3512

Open
MegaByte opened this issue Apr 19, 2024 · 0 comments
Labels
colorspace relates to hte use of color spaces, ICC profiles, etc enhancement New feature or request jpegli Related to jpegli, also cjpegli and djpegli unrelated to 1.0 Things that need not be done before the 1.0 version milestone

Comments

@MegaByte
Copy link

Is your feature request related to a problem? Please describe.
While XYB JPEGs work in many browsers, colors appear wrong in most other apps.

Describe the solution you'd like
Most apps are expecting an Adobe APP14 segment. This is supported in other encoders such as libjpeg-turbo. They describe:

    If TRUE, an Adobe APP14 marker is emitted.  jpeg_set_defaults() and
    jpeg_set_colorspace() set this TRUE if JPEG color space RGB, CMYK,
    or YCCK is selected, otherwise FALSE.

The specific format can be found here.

Additional context
I have tested adding this segment to XYB JPEGs and they show correct colors in other apps like Photoshop, Safari, and macOS Finder/Preview.

@mo271 mo271 added enhancement New feature or request unrelated to 1.0 Things that need not be done before the 1.0 version milestone jpegli Related to jpegli, also cjpegli and djpegli colorspace relates to hte use of color spaces, ICC profiles, etc labels Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
colorspace relates to hte use of color spaces, ICC profiles, etc enhancement New feature or request jpegli Related to jpegli, also cjpegli and djpegli unrelated to 1.0 Things that need not be done before the 1.0 version milestone
Projects
None yet
Development

No branches or pull requests

2 participants