Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Applications shouldn't abort while reading jpegs #3487

Open
ilya-fedin opened this issue Apr 16, 2024 · 1 comment
Open

Applications shouldn't abort while reading jpegs #3487

ilya-fedin opened this issue Apr 16, 2024 · 1 comment
Labels
jpegli Related to jpegli, also cjpegli and djpegli unrelated to 1.0 Things that need not be done before the 1.0 version milestone

Comments

@ilya-fedin
Copy link

ilya-fedin commented Apr 16, 2024 •
edited

Describe the bug
I have noticed 0f0997c. Please don't make it into a release, jpegs are almost always untrusted input and aborting on them is a no-go. The commit message doesn't even explain why this is done... Lots of projects (at least Qt for sure) do setjmp/longjmp trick to recover from error_exit with libjpeg and its forks. The original libjpeg and its forks exit in the default error_exit handler, not after it.
@eustas
Copy link
Contributor

eustas commented Apr 16, 2024

That PR only clarified the current status.
Generally, we are moving towards removing aborts in JXL library; likely we will be able to do so for JPEGLI as well.

@mo271 mo271 added unrelated to 1.0 Things that need not be done before the 1.0 version milestone jpegli Related to jpegli, also cjpegli and djpegli labels Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
jpegli Related to jpegli, also cjpegli and djpegli unrelated to 1.0 Things that need not be done before the 1.0 version milestone
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eustas @mo271 @ilya-fedin