[WIP] Complete rewrite of bindings with nanobind instead of numpyeigen+pybind11 #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major breaking change.
Fixes #110, fixes #242.
In response to fwilliams/numpyeigen#67 this PR is removing the numpyeigen dependency and writing binding code directly.
DRefhandles the row- and column-major ordering issues.Many bindings will have changed slightly. The intention is to always match the corresponding libigl C++ function prototype as closely as possible (still with the major difference being returning outputs instead of using output parameters).
Some old bindings will be missing. I'll try to list those that were intentionally left behind here:
all_pairs_distances: one-liner in numpyNew bindings have been added. Among those, this fixes #230 , fixes #229, fixes #191, fixes #185, fixes #155, fixes #170, fixes #124, fixes #122, fixes #73, fixes #52, fixes #69, fixes #80, fixes #225, fixes #220, fixes #184, fixes #203, fixes #116, fixes #147, fixes #160, fixes #141, fixes #124, fixes #116, fixes #82 …
This PR also introduces typing.