Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPS Simulation and inaccuracy #248

Closed
asatria2 opened this issue Jul 24, 2019 · 4 comments
Closed

GPS Simulation and inaccuracy #248

asatria2 opened this issue Jul 24, 2019 · 4 comments

Comments

@asatria2
Copy link

Hi,

The current simulator GPS output have a tendency to jump around.
from: MapOrigin.cs:35

    public void GetLatitudeLongitude(double northing, double easting, out double latitude, out double longitude)
    {
        // MIT licensed conversion code from https://github.com/Turbo87/utm/blob/master/utm/conversion.py

The simulator gps lat-lon conversion is copied from https://github.com/Turbo87/utm/blob/master/utm/conversion.py

This issue document the inaccuracy of the conversion Turbo87/utm#36

Is there any plan to improve the simulation of the GPS device and fix the conversion? It will be great if the accuracy and noise of the GPS device can be definable and tunable.

@martins-mozeiko
Copy link
Contributor

We'll look into this. Thanks!
Do you have example coordinate values for which the calculation is imprecise?

@asatria2
Copy link
Author

"$GPGGA,050538.197,0.109518,N,0.092640,E,1,10,0.01,10.119778,M,0.000000,M,,*55"
"$GPGGA,050538.592,0.109382,N,0.089306,E,1,10,0.01,10.119258,M,0.000000,M,,*5B"
"$GPGGA,050538.966,0.109518,N,0.085778,E,1,10,0.01,10.118649,M,0.000000,M,,*5D"

The latitude jump from 0.109518 N to 0.109382 N and back again while driving straight.

Thanks.

@daohu527
Copy link
Contributor

daohu527 commented Jul 26, 2019

Very interesting question, is it across time zones? : )

@asatria2
Copy link
Author

Not really, the behavior shows up even without crossing North to South. Crossing it caused other problem but that's related how Autoware handling the conversion from lat-long to xyz.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants