Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Morphing animation messes up San Francisco Display font #61

Open
Sweeper777 opened this issue Jul 25, 2016 · 2 comments
Open

Morphing animation messes up San Francisco Display font #61

Sweeper777 opened this issue Jul 25, 2016 · 2 comments

Comments

@Sweeper777
Copy link

I really like how the colon character (:) is a little bit raised up and not touching the baseline in the San Francisco Display font introduced in WWDC 2015. Here is how it is supposed to look like:

screen shot 2016-07-25 at 3 22 54 pm

However, once I changed the text of the label to something else with the .Fall animation, the colon dropped onto the baseline:

screen shot 2016-07-25 at 3 23 22 pm

I believe that this is caused by the way you draw the text using Core Text. Can you fix it?

@lexrus
Copy link
Owner

lexrus commented Sep 10, 2016

Since the frame of each character was calculated based on NSString.sizeWithAttributes method, I can't figure out the proper origin.y. To be lazy, place on the baseline is just a workaround. The TextKit may help, but I'm not familiar with it yet.

@Sweeper777
Copy link
Author

So would you kindly fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants