-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mdi-react-native #71
Comments
Hey there. Just leave the TypeScript typings out and open a PR. I'll add them to your PR. |
Any updates on this from your side? |
Sorry! We ultimately went with a different approach and I totally forgot about this 🤦♂ |
Just to let you know, I remember about this issue but couldn't find time because of traveling 😅 Please keep it open! |
Any updates on this? |
To be honest due to the global pandemic and everything related to it, I completely forgot about this issue and the code I already had prepared. I sent a PR #79, it still requires TS fixes though. |
Hey! I love your library!
It would be amazing if other than
mdi-react
andmdi-preact
there was a third option,mdi-react-native
. The differences would be tiny:svg
andpath
withimport Svg, { Path } from 'react-native-svg'
fill
needs to be applied onPath
instead ofSvg
I'd love to send a PR but I'm not a TypeScript person so I gave up after trying to fix the typings (sorry!)
Would you be interested in adding this and releasing it as your own library or would you rather not maintain any extra baggage and I should just fork? :)
The text was updated successfully, but these errors were encountered: