Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flow types #35

Open
HenriBeck opened this issue May 28, 2018 · 5 comments
Open

Flow types #35

HenriBeck opened this issue May 28, 2018 · 5 comments
Labels
enhancement

Comments

@HenriBeck
Copy link

Add .js.flow files for every Icon with the flow type
@levrik
Copy link
Owner

levrik commented Jun 1, 2018

@HenriBeck Since I'm not using flow type by myself it would be awesome if you could open a PR.

@HenriBeck
Copy link
Author

Ok, the only problem that might come up is that the components are generated twice, right? Once of the index module and once for the single files

Sent with GitHawk

@levrik
Copy link
Owner

levrik commented Jun 14, 2018

@HenriBeck Is that a problem for typings? It works fine for TypeScript.

@HenriBeck
Copy link
Author

Maybe, I haven't got around to work on this. I might have some time on the weekend.
Will let you know when I tested it.

@levrik
Copy link
Owner

levrik commented Dec 3, 2018

Hey @HenriBeck.
The index module got removed in 5.0.0
Maybe you want to try again with Flow typings?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HenriBeck @levrik