Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The SA can store a requested profile alongside an order #7324

Closed
Tracked by #7309
aarongable opened this issue Feb 13, 2024 · 1 comment · May be fixed by #7842
Closed
Tracked by #7309

The SA can store a requested profile alongside an order #7324

aarongable opened this issue Feb 13, 2024 · 1 comment · May be fixed by #7842
Assignees
@pgporada
Milestone
Sprint 2024-04-02

Comments

@aarongable
Copy link
Contributor

aarongable commented Feb 13, 2024 •
edited
Loading

Add a profile field to the SA's NewOrder request object.
Decide where to store it: a new column in the orders table? a new table?
Add a profile field to the SA's GetOrder response object.

We've decided to store nothing in the case that the client does not explicitly request a profile, so the default can be selected at finalize time.
@aarongable aarongable mentioned this issue Feb 13, 2024
Open
15 tasks
@aarongable aarongable self-assigned this Feb 13, 2024
@aarongable aarongable added this to the Sprint 2024-02-13 milestone Feb 13, 2024
@pgporada pgporada mentioned this issue Mar 5, 2024
Merged
pgporada added a commit that referenced this issue Mar 20, 2024
@pgporada
SA: store and return certificate profile name (#7352)
8556eae 
Adds `certificateProfileName` to the `orders` database table. The
[maximum
length](https://github.com/letsencrypt/boulder/pull/7325/files#diff-a64a0af7cbf484da8e6d08d3eefdeef9314c5d9888233f0adcecd21b800102acR35)
of a profile name matches the `//issuance` package.

Adds a `MultipleCertificateProfiles` feature flag that, when enabled,
will store the certificate profile name from a `NewOrderRequest`. The
certificate profile name is allowed to be empty and the database will
treat that row as [NULL](https://mariadb.com/kb/en/null-values/). When
the SA retrieves this potentially NULL row, it will be cast as the
golang string zero value `""`.

SRE ticket IN-10145 has been filed to perform the database migration and
enable the new feature flag. The migration must be performed before
enabling the feature flag.

Part of #7324
@pgporada pgporada mentioned this issue Apr 2, 2024
Open
@pgporada
Copy link
Member

pgporada commented Apr 2, 2024

I'm closing this because the SA now has this support. Cleanup to remove orderModelv1 will be done in #7408.

@pgporada pgporada closed this as completed Apr 2, 2024
@aarongable aarongable mentioned this issue Nov 22, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pgporada pgporada

Labels
None yet
Projects
None yet
Milestone
Sprint 2024-04-02
Development

Successfully merging a pull request may close this issue.

Clean up MultipleCertificateProfiles feature flag letsencrypt/boulder
4 participants
@jsha @pgporada @aarongable @beautifulentropy