Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes inherited net= inside symbol overrides net= attached to it. #143

Open
vzh opened this issue Jul 11, 2017 · 5 comments
Open

Sometimes inherited net= inside symbol overrides net= attached to it. #143

vzh opened this issue Jul 11, 2017 · 5 comments

Comments

@vzh
Copy link
Member

vzh commented Jul 11, 2017

Sometimes inherited net= inside symbol overrides net= attached to
it. See, e.g., the net connected to U500:10 from
gnd-custom.sym inside gnetlist/tests/common/netattrib.sch,
having inherited net=DIGITAL_GND:1 and attached net=DGND:1.

How to reproduce

$ gnetlist -g geda -o - common/netattrib.sch |grep "U500 10"
DIGITAL_GND : U500 10

@graahnul-grom
Copy link
Member

graahnul-grom commented Apr 16, 2019

Launching netlist -g geda -o - common/netattrib.sch gives the following
errors, prefixed by
"** (process:< PID here >): CRITICAL **: < system time here >: ":

Found duplicate net name, renaming two to one
Rename shorted nets (net= has priority): out3 -> signal3
Rename shorted nets (net= has priority): out8 -> signal8
Found duplicate net name, renaming GND to sig9

@graahnul-grom
Copy link
Member

@vzh Why "sometimes" in the title?

@vzh
Copy link
Member Author

vzh commented Apr 26, 2019

@graahnul-grom, well, if the word "sometimes" is confusing here, probably "in some cases" would be better?

@graahnul-grom
Copy link
Member

@vzh It's not about wording, I'm asking because whenever I run this command (and on various systems), it always produces the output shown above. In what cases it gives a different result?

@vzh
Copy link
Member Author

vzh commented May 5, 2019

OK, the reason I'd written this was using of different approaches in gnetlist and its backends for working with attributes in many various places. Since then, several things have changed. My intention, when writing of this issue, was to standardize what attribs should be used for netlisting. You could remember or look through the commit history that I added new tests to show what issues we have. Some of them have been discussed on the geda-user list though have never been fixed. Some backends continue today parsing of attributes' text representation, IIRC. Here, I'm suggesting to fix such (sometimes wrong) usage of attribs and write TRT down explicitly somewhere. Please feel free to add your suggestion, changes to the topic description, etc. I have to emphasize here, it's all about standardization of attributes' usage (which, however, can cause some unexpected backward incompatible changes...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants