Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] False positive: "Version mismatch detected" for non-numeric flutter versions #666

Open
AndreasMattsson opened this issue Feb 28, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@AndreasMattsson
Copy link

AndreasMattsson commented Feb 28, 2024

Describe the bug
fvm commands halt prompting the user for "version mismatch" resolution if attempting to use a version with a non-numeric name (i.e. doesn't match X.Y.Z).

Regardless of which conflict resolution option is chosen the same version mismatch warning will be shown again on the next fvm command.

To Reproduce

fvm use v1.15.17
fvm flutter --version
⚠ Version mismatch detected: cache version is 1.15.17, but expected v1.15.17.

fvm use 1.17.0-dev.3.1
fvm flutter --version
⚠ Version mismatch detected: cache version is 1.17.0, but expected 1.17.0-dev.3.1.

vs Working Case

fvm use 1.17.0
fvm flutter --version
# all good, no warning!

Expected behavior
Should not be warned of mismatch just because version name doesn't match an arbitrary numeric pattern.

Logs
--verbose provide any additional output before mismatch warning (see above).

Desktop

  • OS: Windows
  • FVM Version 3.0.12
  • If Windows: Git Bash for Windows

Additional context
Flutter stopped prepending their version names with v between v1.15.17 and 1.17.0, however ideally fvm should work as expected even for.

Issue discovered and discussed in PR 654.

@AndreasMattsson AndreasMattsson added the bug Something isn't working label Feb 28, 2024
chrisirhc added a commit to chrisirhc/zulip-flutter that referenced this issue Mar 22, 2024
chrisirhc added a commit to chrisirhc/zulip-flutter that referenced this issue Mar 22, 2024
make fvm flutter version match pubsec

ci: update CI to use fvm

WIP don't remove checkout

use flutter binary directly from .fvm directory

See leoafarias/fvm#666

sketch of a .envrc for using fvm's flutter

use dotenvrc approach

Revert "use flutter binary directly from .fvm directory"

This reverts commit 570f150.

just use flutter in path

add notes in notice

add note to comment out check flutter version

update README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant