-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] False positive: "Version mismatch detected" for non-numeric flutter versions #666
Labels
bug
Something isn't working
Comments
chrisirhc
added a commit
to chrisirhc/zulip-flutter
that referenced
this issue
Mar 22, 2024
chrisirhc
added a commit
to chrisirhc/zulip-flutter
that referenced
this issue
Mar 22, 2024
make fvm flutter version match pubsec ci: update CI to use fvm WIP don't remove checkout use flutter binary directly from .fvm directory See leoafarias/fvm#666 sketch of a .envrc for using fvm's flutter use dotenvrc approach Revert "use flutter binary directly from .fvm directory" This reverts commit 570f150. just use flutter in path add notes in notice add note to comment out check flutter version update README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
fvm
commands halt prompting the user for "version mismatch" resolution if attempting to use a version with a non-numeric name (i.e. doesn't match X.Y.Z).Regardless of which conflict resolution option is chosen the same version mismatch warning will be shown again on the next
fvm
command.To Reproduce
vs Working Case
Expected behavior
Should not be warned of mismatch just because version name doesn't match an arbitrary numeric pattern.
Logs
--verbose
provide any additional output before mismatch warning (see above).Desktop
Additional context
Flutter stopped prepending their version names with v between v1.15.17 and 1.17.0, however ideally fvm should work as expected even for.
Issue discovered and discussed in PR 654.
The text was updated successfully, but these errors were encountered: