Developers conversations

[leikoilja]

👋 Welcome!

Since we are multiple developers from all over the place let's try using github's "Discussions" feature to chat about any issues, ideas or things we want to, before we take it to the "Projects" board and create reals tasks (aka issues) from them.

I have never used this feature before, but it would be great to try it as a tool while collaborating 😄

[leikoilja]

@DurgNomis-drol, sorry, I ll move your "off-topic" question from the issue here, to the discussion.

You were basically asking if we are aiming to release it as a custom component or to merge it into the core of Home Assistant.

@DurgNomis-drol, it's up to us to decide, but apart of convenience, I see no point of trying to get it into HA core at this point. I am currently working on refactoring habitica integration in HA core and my PR was work in progress ever since August 2020. It will take enormous effort and much more refactoring to implement it in the core repo. I propose we just focus on making it in sort-of following stages:

• Making it work together with glocaltokens
• Finding a way to eliminate the need to manually installing system-wise compliler libraries (like gcc, g++, linux-headers) - maybe by opening issues at HA repos to propose to include these libraries as defaults when building containers
• Release this integration into HACS store
• Get some users testing it and refactor/fix/enhance when more usage is seen
• And only then get back to this discussion to decide together if we want to move it into HA core

[DurgNomis-drol]

This sounds like a wise choice for now. 😄 I wasn't think of doing it straight away anyway, so lets leave it as you say for now.

This is an awesome feature that I didn't know existed! 😄

[ArnyminerZ]

Yeah, I've used python for quite a long time, but it keeps confusing me in some things. It's really different from good old languages such as Java, or all the Cs

[DurgNomis-drol]

I'm an electrian in my daily work, so this is only for fun. I have never had any formal training in programing, so sometimes i have read up on some of the things you guys talk about 😉

I have a hardtime understanding C and Java.

[ArnyminerZ]

Don't worry, it's normal to get confused, I said the Cs and Java because they are older, and people usually like them just for being older. Just joking 😆

[leikoilja]

haha, as long as it's not some sort of sketchy css, I'm game 😄 i always get confused with design part, especially when they start putting in some hard complex structures, css-processors etc etc 😄

[ArnyminerZ]

I happens to me the same, I can never manage to create beautiful UIs 😢 I always end up using classics like Bootstrap

[leikoilja]

Also, an interesting resource I came across is integration score - https://developers.home-assistant.io/docs/integration_quality_scale_index/ 💥

[DurgNomis-drol]

Good find! 😄

I think it a good idea for us to have this in minded when further developing the integration, so if we eventually decides to try to get it included in HA, it will be a lot easier.

[DurgNomis-drol]

Yes, i will test it to night. I run Homeassistant in a container so i can't help with the HACS part of the readme, but I also think we should provide a installation method for those who use it in docker (like me)

[leikoilja]

Ou, that's good to know. Yeh, let's keep both options available - HACS and manual installation :)

[DurgNomis-drol]

I can confirm that installing it manual seems too work, grpcio, grpcio-tools and glocaltokens installs automatically.

I will make changes to README that describes how to do that :)

See #51 for an issue i found

[DurgNomis-drol]

Do you now what the minimum required version of HA is? I have only tested it with 2021.3 because I wouldn't install below that

[leikoilja]

No, I don't... but let's just put the current version that we have tested it with and support further on 🤷‍♂️😂

[KapJI]

Awesome! 🚀
Please also update manifest.json 🙂

[leikoilja]

Yep, thanks for the spot! Updated ✅

[DurgNomis-drol]

Awesome! 🎉 🥳

[DurgNomis-drol]

I just installed v1 and it just works 😄 This has been my first project and i have learned so much from it 🎉

I think everybody did an awesome job!

[leikoilja]

Hey-hey dev team! 💥
Some super exciting news! I'm stocked to announce that a talented developer @Drakulix is also joining our team after discussions to merge two ongoing projects ha-google-home and googlehome 🚀
He was actively working on a fork of the original HA Google Home component before its depreciation introducing some near workarounds.
Welcome, @Drakulix 💥 💯

[KapJI]

Welcome, @Drakulix!

[KapJI]

I like the idea that API calls should be moved to external package like googledevices, I think we eventually should do that.

[Drakulix]

Thanks for the kind introduction! Hey everybody 👋

[DurgNomis-drol]

@Drakulix Welcome to the team 😁

[ArnyminerZ]

I like the idea that API calls should be moved to external package like googledevices, I think we eventually should do that.

I also think it should be done, but isn't that what glocaltokens does? Or do we wanna keep glocaltokens as the "token getter", and create a new package like googledevices as you have stated for the API calls?
Maybe we should open an issue for discussing this, or even an exclusive discussion since I believe this is quite an important change.

[DurgNomis-drol]

Did 2021.4 break your setup? 😞

Yeah i think that would be great 😃

[ArnyminerZ]

@leikoilja @KapJI @DurgNomis-drol I'm starting to develop some scripts for loading Eureka into the Integration, but I don't think every single element from it should be stored, since as you can see in GHKAPI there are quite a few, which ones do you think that we should load in?

I put here a list with all the available parameters, and I believe we should choose which ones to include and which not:

• version
• audio
• name
• build_info
• detail
• device_info
• net
• wifi
• setup
• settings
• opt_in
• opencast
• multizone
• proxy
• night_mode_params
• user_eq
• room_equalizer
• sign
• aogh
• ultrasound
• mesh

It might even be possible to include all of them, maybe on different entities, but I find it too much and unnecessary, what do you think?

[ArnyminerZ]

I like both the ideas of loading the data from glocaltokens and from another package. For me, glocaltokens is looking really clean, so adding more code like the API loading to glocaltokens seems a bit excessive for me, so I'd create a new package. Whatsoever, both options should work.

[leikoilja]

My concerns are that it become too many packages around doing similar things :D makes it harder to maintain when things are scattered. glocaltokens is called tokens but in reality we are already doing more then just tokens (we fetch google devices from homegraph, their corresponding tokens and device models, do zeroconf to find their local IP).

There is already a googledevices package out there that does some API calls and seems like have some good coding practises in place. It's not maintained, so I would be more happy if we fork or "rewrite" our own implementation (either into glocaltokens and rename it to ...(smth more generic)) or creating a new package that we'll use in ha-google-home later. That would leave a complete control of repo/project to us making it much easier to maintain and work with

[KapJI]

I think it's cleaner to have isolated scope for each package. E.g. glocaltokens should only interact with HomeGraph API to fetch local tokens. Zeroconf is probably better to be moved to component itself and pass discovered devices to glocaltokens. API calls to actual devices can be also in a separate package like googledevices.

We can either fork it, get us added as maintainers there or create something new from the scratch by just extracting some code from the component.

[ArnyminerZ]

I agree with @leikoilja because if there's a small fix to be made on a package, it's harder to get it fixed on the others, if everything is on the same package it's easier. But @KapJI also has a point on specialization, since having different packages doesn't mean that it's harder to find errors, it would be even easier, because if we know exactly what each package does, it can be easier to make fixes, and add new features.
Also, on the googledevices package i find it to be a bit too large for our needs, we want something simpler, just requests and parsing, so it can be a good option to take some code from them, but not the whole project, since I think it has a different focus.
Overall, I'd personally create a new package, because of specialization; even though it's harder to create updates, I think this approach should be more maintenable. But I'm open for both options, so whatever you want, will be good for me.

[leikoilja]

Okay, gents, i have just set up a repo where we can start tweaking things together. I have intentionally left the main directory google-home-api empty so we can start with a whole new structure including typing (from the ground up in every commit) and unit testing. This is going to be BIG! 🤩
I have also made all the collaborators the same as this repo.

Any thoughts? I have also enabled discussions in that repo where we can discuss things related to that particular project :) 🚀

[DurgNomis-drol]

Hey guys!! Glad to see you all are still working on it!

For me the integration have not worked for a while, i am having the problem described here #202. It is very severe for me and makes my Google Home unstable and the same for my Home Assistant installation. After disabling it works again. 😭

I will just say that i won't be actively helping anymore, but will monitor to see if a solution is found or maybe i am lucky enough that google will fix there software at some point 🤞

I will also not continue maintaining the card i have created. But if anyone of you are interested in doing so, you are more then welcome to be a collaborator on it or fork it. Or else I will deprecated it very soon. 😢

[mendevi]

I'm sorry if this info is out there, but I can't seem to find it.

I would like to know if the NodeRed flow linked below the Readme can work for iPhones using the IOS App. It states Android, but nowhere does it mention IOS or not.

Thank you.

[leikoilja]

@mendevi, you need to contact @mattieha who has implemented the NodeRed flow. You can try reaching him out straight or mention on the PR he created for example here

[stboch]

@leikoilja FYI this shouldn't be an issue since this is already the version you are using but looks like the base version of the google-api-python-client is finally getting updated...
home-assistant/core#67298

[leikoilja]

Awesome! Thanks for the heads up, @stboch. We have just specified that requirement in manifest.json (#472), however we can probably drop it in the next HA release :)