Support for passing git version as a argument to runMain?

[KireinaHoro]

I'm trying to pass the git version string generated by this plugin to a main class on invocation, but somehow mill doesn't allow me to do so:

trait HwProjModule extends Module {                                             
  def variant: String                                                           
  def generatedSourcesPath = millSourcePath / "hw" / "gen" / variant            
  override def millSourcePath = os.pwd                                          
                                                                                
  def gitVersion = T { VcsVersion.vcsState().format() }                         
                                                                                
  def generateVerilog = T {                                                        
    val v = gitVersion()                                                           
    gen.runMain("pionic.GenEngineVerilog",                                         
      "--name", variant,                                                           
      "--version", v)()                                                            
                                                                                   
    Seq("NicEngine_ips.v", "NicEngine.v", "NicEngine.xdc").map(fn => PathRef(generatedSourcesPath / fn))
  }
  // ...
}

Results in the following error:

$ mill eci.generateVerilog
[build.sc] [49/53] compile 
[info] compiling 1 Scala source to /local/home/pengxu/work-local/enzian-pio-nic/out/mill-build/compile.dest/classes ...
[error] /local/home/pengxu/work-local/enzian-pio-nic/build.sc:60:20: Target#apply() call cannot use `value v` defined within the T{...} block
[error]       "--version", v)()
[error]                    ^
[error] one error found
1 targets failed
compile Compilation failed

Is this a supported use case of the module? Thanks!

[lefou]

Since the version comes from a target, you need a run-version that has receives a Task for the run arguments. Unfortunatelly, runMain isn't one of them (only in the next major Mill version, due to compatibility reasons). Either you use run or the underlying runForkedTask.

  def generateVerilog = T {
    gen.runForkedTask(
      mainClass = T.task { "pionic.GenEngineVerilog" },
      args = T.task { 
        val v = gitVersion()
        Args("--name", variant, "--version", v) 
      }
    )()

    Seq("NicEngine_ips.v", "NicEngine.v", "NicEngine.xdc").map(fn => PathRef(generatedSourcesPath / fn))
  }

I'm referring to Mill 0.11.7-70-654f58

[KireinaHoro]

I'm getting a complaint about runForkedTask not found:

[info] compiling 1 Scala source to /local/home/pengxu/work-local/enzian-pio-nic/out/mill-build/compile.dest/classes ...
[error] /local/home/pengxu/work-local/enzian-pio-nic/build.sc:57:9: value runForkedTask is not a member of object build.this.gen
[error]     gen.runForkedTask(
[error]         ^
[error] /local/home/pengxu/work-local/enzian-pio-nic/build.sc:58:7: not found: value mainClass
[error]       mainClass = T.task { "pionic.GenEngineVerilog" },
[error]       ^
[error] /local/home/pengxu/work-local/enzian-pio-nic/build.sc:59:7: not found: value args
[error]       args = T.task {
[error]       ^
[error] three errors found

I'm on mill 0.11.6. Is this newly added?

Just in case, here's the definition of gen:

trait CommonModule extends ScalaModule {                                        
  override def scalaVersion = v.scalaVersion                                    
  override def millSourcePath = os.pwd                                          
  override def sources = T.sources(                                             
    millSourcePath / "hw" / "spinal"                                            
  )                                                                             
  override def scalacOptions = super.scalacOptions() ++ spinalIdslPlugin.pluginOptions()
  override def moduleDeps = super.moduleDeps ++ Agg(blocks, spinalCore, spinalLib)
                                                                                
  override def ivyDeps = Agg(                                                   
    ivy"com.lihaoyi::mainargs:0.5.4",                                           
  )                                                                             
}        
object gen extends CommonModule { outer =>                                      
  object test extends ScalaTests with TestModule.ScalaTest {                    
    override def moduleDeps = super.moduleDeps ++ Agg(spinalTester)             
    override def millSourcePath = outer.millSourcePath                          
    override def sources = T.sources(millSourcePath / "hw" / "tests")           
                                                                                
    override def ivyDeps = Agg(                                                 
      ivy"com.lihaoyi::os-lib:0.9.3",                                           
      ivy"commons-io:commons-io:2.15.1",                                        
    )                                                                           
  }                                                                             
}

[KireinaHoro]

Ah it does work for 0.11.7-70-654f58. Thanks!

[lefou]

Yeah, we refactored the run-targets into a new shared RunModule after the release of Mill 0.11.7.

If you can't or don't want to switch to a prerelease version, you can either use the run target and also set the mainClass, or you need to copy-and-paste the implementation of runMain.

[KireinaHoro]

I just switched to the pre-release version for now, thanks!