Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge vscode-lean4-code-actions? #316

Open
DenisGorbachev opened this issue Aug 24, 2023 · 1 comment
Open

Merge vscode-lean4-code-actions? #316

DenisGorbachev opened this issue Aug 24, 2023 · 1 comment

Comments

@DenisGorbachev
Copy link
Contributor

Hi @Vtec234 @gebner !

I've published a new VSCode extension for code actions.

Mario suggested merging this extension into vscode-lean4 in the Zulip thread.

Pros:

  • Users won't need to install two extensions.

Cons:

  • Lower release speed: the PRs would need to go through the review process.
  • Lower dev speed: I'll have to adjust to the code style, packages, testing framework, etc (or we could have lengthy discussions, but that would result in even lower speed).

Are there any missing pros / cons?

What do you think in general: should we merge?

@kim-em
Copy link
Contributor

kim-em commented Aug 25, 2023

Not if it involves parsing Lean code using regexes from another language. That would not be maintainable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants