Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: DecidableRel allows a heterogeneous relation #6341

Merged
merged 1 commit into from
Dec 11, 2024
Merged

chore: DecidableRel allows a heterogeneous relation #6341

merged 1 commit into from
Dec 11, 2024

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Dec 9, 2024

This PR generalizes DecidableRel to allow a heterogeneous relation.

@kim-em kim-em added the changelog-library Library label Dec 9, 2024
@kim-em kim-em requested a review from tydeu as a code owner December 9, 2024 05:59
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 9, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Dec 9, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#6341
2278857
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc December 9, 2024 06:18 Inactive
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Dec 9, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#6341
6f7773e
@leanprover-community-bot leanprover-community-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Dec 9, 2024
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Dec 9, 2024 •
edited
Loading

Mathlib CI status (docs):

@YaelDillies
Copy link

What is your suggested replacement for all the @DecidableRel α (· ≤ ·) that appear in mathlib?

@kim-em
Copy link
Collaborator Author

kim-em commented Dec 9, 2024

What is your suggested replacement for all the @DecidableRel α (· ≤ ·) that appear in mathlib?

Presumably (\a := \a)?

@kim-em kim-em mentioned this pull request Dec 9, 2024
Closed
@leanprover-community-bot leanprover-community-bot added builds-mathlib CI has verified that Mathlib builds against this PR and removed breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan labels Dec 10, 2024
@YaelDillies
Copy link

Hmm, maybe that warrants a dedicated abbrev DecidableLE then (and similarly for LT)

@kim-em
Copy link
Collaborator Author

kim-em commented Dec 10, 2024

Hmm, maybe that warrants a dedicated abbrev DecidableLE then (and similarly for LT)

Sounds good. I propose we install this in Mathlib first, and it can move upstream if necessary later.

@kim-em kim-em added this pull request to the merge queue Dec 11, 2024
Merged via the queue into master with commit 8709ca3 Dec 11, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tydeu tydeu Awaiting requested review from tydeu tydeu is a code owner

Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kim-em @leanprover-community-bot @YaelDillies