Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't filter out local instances in LCNF toMono pass #6664

Merged
merged 1 commit into from
Jan 17, 2025
Merged

fix: don't filter out local instances in LCNF toMono pass #6664

merged 1 commit into from
Jan 17, 2025

Conversation

zwarich
Copy link
Contributor

@zwarich zwarich commented Jan 16, 2025

This PR changes the toMono pass to longer filter out type class instances, because they may actually be needed for later compilation.

@zwarich
fix: don't filter out local instances in LCNF toMono pass
db53d39 
This filters out type class instances that are required for
later compilation. Given our current compilation model, this
seems unlikely to change.
@zwarich zwarich added the changelog-compiler Compiler, runtime, and FFI label Jan 16, 2025
@zwarich zwarich requested a review from leodemoura as a code owner January 16, 2025 06:30
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jan 16, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 65175dc7d483fc8a65bb4851fb3bbdd2cc6f6ea6 --onto a955708b6c5f25e7f9c9ae7b951f8f3d5aefe377. (2025-01-16 06:55:41)

@leodemoura leodemoura added this pull request to the merge queue Jan 17, 2025
Merged via the queue into leanprover:master with commit 7f0ae22 Jan 17, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leodemoura leodemoura Awaiting requested review from leodemoura leodemoura is a code owner

Assignees
No one assigned
Labels
changelog-compiler Compiler, runtime, and FFI toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zwarich @leanprover-community-bot @leodemoura