Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: run Batteries linter on Lean #6364

Merged
merged 9 commits into from
Dec 13, 2024
Merged

chore: run Batteries linter on Lean #6364

merged 9 commits into from
Dec 13, 2024

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Dec 10, 2024 •
edited
Loading

This PR makes fixes suggested by the Batteries environment linters, particularly simpNF, and unusedHavesSuffices.

@kim-em kim-em added the changelog-library Library label Dec 10, 2024
@kim-em kim-em requested review from TwoFX and digama0 as code owners December 10, 2024 22:53
@kim-em
Copy link
Collaborator Author

kim-em commented Dec 10, 2024

Pinging @tobiasgrosser and @luisacicolini, as this suggested changes in BitVec/Lemmas.lean that touched code from your PRs. We're hoping to just have this linter running in Lean CI at some point (soon?), but for now these are just things to watch out for.

@kim-em kim-em enabled auto-merge December 10, 2024 22:54
@kim-em kim-em requested a review from hargoniX as a code owner December 11, 2024 00:40
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc December 11, 2024 10:52 Inactive
@kim-em kim-em added this pull request to the merge queue Dec 11, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 11, 2024
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Dec 11, 2024 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase cd909b0a98a14b5fb08a6a85e01470ec65dbe5c5 --onto 8709ca35e9ddb977f7d050751e04981e2ab0d5c7. (2024-12-11 11:04:08)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase cd909b0a98a14b5fb08a6a85e01470ec65dbe5c5 --onto 48be424eaa2ae06972e9cfec4d355906b532204d. (2024-12-12 23:03:43)
  • 💥 Mathlib branch lean-pr-testing-6364 build failed against this PR. (2024-12-13 02:12:56) View Log

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 11, 2024
@kim-em kim-em added this pull request to the merge queue Dec 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 11, 2024
@kim-em kim-em added this pull request to the merge queue Dec 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 11, 2024
@kim-em kim-em added this pull request to the merge queue Dec 12, 2024
@kim-em kim-em removed this pull request from the merge queue due to a manual request Dec 12, 2024
@kim-em kim-em added the release-ci Enable all CI checks for a PR, like is done for releases label Dec 12, 2024
@kim-em kim-em added this pull request to the merge queue Dec 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 12, 2024
@kim-em kim-em enabled auto-merge December 13, 2024 00:33
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc December 13, 2024 00:35 Inactive
@kim-em kim-em added this pull request to the merge queue Dec 13, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Dec 13, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#6364
0eb9f8b
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Dec 13, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#6364
43e38df
Merged via the queue into master with commit db354d2 Dec 13, 2024
24 checks passed
@leanprover-community-bot leanprover-community-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasgrosser tobiasgrosser tobiasgrosser approved these changes

@TwoFX TwoFX Awaiting requested review from TwoFX TwoFX is a code owner

@digama0 digama0 Awaiting requested review from digama0 digama0 is a code owner

@hargoniX hargoniX Awaiting requested review from hargoniX hargoniX is a code owner

Assignees
No one assigned
Labels
breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan changelog-library Library release-ci Enable all CI checks for a PR, like is done for releases toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kim-em @leanprover-community-bot @tobiasgrosser