-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: lean --error=kind
#6362
feat: lean --error=kind
#6362
Conversation
Small objection that |
Mathlib CI status (docs):
|
Note the syntax here is |
Separately, this could also use a test but it is not clear to me where in |
892145e
to
29f9614
Compare
This PR adds the
--error=kind
option (shorthand:-Ekind
) to thelean
CLI. When set, messages ofkind
(e.g.,linter.unusedVariables
) will be reported as errors. This setting does nothing in interactive contexts (e.g., the server).Closes #5194.
The spelling
--error
was chosen instead of the common-Werror
both for practical and behavioral reasons. Behaviorally, this option effects not just warnings, but informational messages as well. Practically,-Werror
conflicts with the existing-W
option for the worker andlean
also does not currently use long single-hyphen option names.