Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove @[simp] from Fin.succ_zero_eq_one #6292

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

feat: remove @[simp] from Fin.succ_zero_eq_one #6292

wants to merge 2 commits into from

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Dec 3, 2024

An experiment to check downstream fallout.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 3, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Dec 3, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#6292
116071b
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Dec 3, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#6292
576cc5a
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc December 3, 2024 00:22 Inactive
@leanprover-community-bot leanprover-community-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Dec 3, 2024
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Dec 3, 2024 •
edited
Loading

Mathlib CI status (docs):

  • 💥 Mathlib branch lean-pr-testing-6292 build failed against this PR. (2024-12-03 00:56:02) View Log
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 904404303b5b7f2f597498af14f793ab72d82c87 --onto 3c5e612dc54733cd707becb929457d2f9d8ca6fd. (2024-12-03 01:59:13)
  • 💥 Mathlib branch lean-pr-testing-6292 build failed against this PR. (2024-12-03 05:51:46) View Log
  • 💥 Mathlib branch lean-pr-testing-6292 build failed against this PR. (2024-12-03 07:03:25) View Log

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc December 3, 2024 02:00 Inactive
@kim-em
Copy link
Collaborator Author

kim-em commented Dec 3, 2024

Let's try #6295 first; that might resolve the Mathlib breakage.

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc December 3, 2024 04:35 Inactive
@kim-em kim-em removed breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN labels Dec 3, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 3, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Dec 3, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#6292
2596e24
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Dec 3, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#6292
559f03b
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc December 3, 2024 05:22 Inactive
@leanprover-community-bot leanprover-community-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leodemoura leodemoura Awaiting requested review from leodemoura leodemoura will be requested when the pull request is marked ready for review leodemoura is a code owner

Assignees
No one assigned
Labels
breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kim-em @leanprover-community-bot