Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alias, deprecated, and to_additive don't get along togther #19424

Open
Tracked by #1074
kim-em opened this issue Nov 23, 2024 · 1 comment
Open
Tracked by #1074

alias, deprecated, and to_additive don't get along togther #19424

kim-em opened this issue Nov 23, 2024 · 1 comment

Comments

@kim-em
Copy link
Contributor

kim-em commented Nov 23, 2024

Unfortunately,

@[to_additive (attr := deprecated (since := "date"))] alias foo_mul := bar_mul

only attaches the replacement name to foo_mul, not to foo_add, and so we need to add the replacement foo_add -> bar_add in a separate attribute statement.

@kim-em
Copy link
Contributor Author

kim-em commented Nov 24, 2024

(This is a tracking issue: as of #19426, all such occurrences in Mathlib have a link to this issue.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant