Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalise Asymptotics API to drop commutative assumptions #19288

Open
grhkm21 opened this issue Nov 20, 2024 · 0 comments
Open

Generalise Asymptotics API to drop commutative assumptions #19288

grhkm21 opened this issue Nov 20, 2024 · 0 comments

Comments

@grhkm21
Copy link
Collaborator

grhkm21 commented Nov 20, 2024

Extracted from #16015. A lot of lemmas in Analysis/Asymptotics/Asymptotics.lean have unnecessary commutative requirements. For example, by applying the follow change on line 59:

- variable [SeminormedAddCommGroup E'] [SeminormedAddCommGroup F'] [SeminormedAddCommGroup G']
+ variable [SeminormedAddGroup E'] [SeminormedAddGroup F'] [SeminormedAddGroup G']

One only gets 50 errors in the file, with the first error occurring on line 623, despite there being more theorems using those variables:

rg "^theorem.+[EFGfgk]'[^']" Mathlib/Analysis/Asymptotics/Asymptotics.lean | wc -l
104

Relevant files that may also require fixing include Mathlib/Analysis/Normed/Field/Basic.lean (e.g. theorem norm_norm doesn't require commutativity), as they are used in the Asymptotics file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant