Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for .cbr and .cbz files (comics) in the app viewer #1377

Closed
LavRadis opened this issue Apr 23, 2018 · 10 comments
Closed

Add support for .cbr and .cbz files (comics) in the app viewer #1377

LavRadis opened this issue Apr 23, 2018 · 10 comments
Assignees
Labels
area: ux area: viewer hacktoberfest Welcome to Hacktoberfest help wanted level: 2 Some knowledge of the existing code is recommended needs: exploration Solution unclear, needs research type: improvement Existing (or partially existing) functionality needs to be changed type: new feature New functionality that does not exist yet

Comments

@LavRadis
Copy link
Contributor

The Issue

We had a comic author in the Discord who is interested in publishing his work on LBRY. Comics are a huge market and a lot of them come in .cbz or .cbr format (rar or zip files with images) or PDF. It would be great if we could have an in-app comic file viewer. There should be many open source viewers available. Here is one: https://github.com/codedread/kthoom

@LavRadis LavRadis changed the title Enable support for .cbr and .cbz files (comics) in the app viewer Add support for .cbr and .cbz files (comics) in the app viewer Apr 23, 2018
@tzarebczan
Copy link
Contributor

Thanks for opening this @LavRadis !

@tzarebczan tzarebczan added area: ux needs: exploration Solution unclear, needs research help wanted level: 2 Some knowledge of the existing code is recommended type: new feature New functionality that does not exist yet area: viewer and removed needs: triage labels Apr 23, 2018
@btzr-io btzr-io self-assigned this Apr 23, 2018
@btzr-io
Copy link
Collaborator

btzr-io commented Apr 23, 2018

@LavRadis I'm currently working on one, it's open source and should be easy to integrate using an iframe or a react-component, I'll try to make a demo for next week...

If you have any features in mind just post it here.

@btzr-io
Copy link
Collaborator

btzr-io commented Apr 24, 2018

Related #932

@btzr-io btzr-io added the type: improvement Existing (or partially existing) functionality needs to be changed label Apr 24, 2018
@btzr-io
Copy link
Collaborator

btzr-io commented May 10, 2018

@LavRadis
Copy link
Contributor Author

@btzr-io I've tested it and it works great!

@btzr-io btzr-io mentioned this issue Jun 29, 2018
3 tasks
@neb-b
Copy link

neb-b commented Oct 16, 2018

@btzr-io Any plans to add that viewer for comics?

@alyssaoc alyssaoc added the hacktoberfest Welcome to Hacktoberfest label Oct 16, 2018
@btzr-io
Copy link
Collaborator

btzr-io commented Oct 16, 2018

@seanyesmunt currently is a web app, not sure if an iframe would work 🙃

@btzr-io
Copy link
Collaborator

btzr-io commented Oct 16, 2018

If not we need to port it to a react component 😛

@neb-b
Copy link

neb-b commented Oct 16, 2018

Ah I didn't realize that. Ok. Well this isn't a high priority, maybe someone will pick it up.

@btzr-io
Copy link
Collaborator

btzr-io commented May 10, 2019

Due to the complexity of this viewer I decided to create a separate modular component:

Small update on this issue:
I created a new react component (WIP) but it should be compatible with preact:
https://github.com/btzr-io/Villain

workhorsy/comic_book_reader#121 (comment)

@btzr-io btzr-io mentioned this issue May 23, 2019
9 tasks
@btzr-io btzr-io closed this as completed May 31, 2019
jessopb pushed a commit that referenced this issue Jul 15, 2022
* Adjust theater mode and image pages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ux area: viewer hacktoberfest Welcome to Hacktoberfest help wanted level: 2 Some knowledge of the existing code is recommended needs: exploration Solution unclear, needs research type: improvement Existing (or partially existing) functionality needs to be changed type: new feature New functionality that does not exist yet
Projects
None yet
Development

No branches or pull requests

6 participants