Correctly use ref parameters when flashing taskbar icon (#1236)

lay295 · Oct 28, 2024 · e272112 · e272112
1 parent 594c990
commit e272112
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/TwitchDownloaderWPF/MainWindow.xaml.cs b/TwitchDownloaderWPF/MainWindow.xaml.cs
@@ -153,7 +153,7 @@ private async void FlashTaskbarIconIfNotForeground(TimeSpan flashDuration)
                 FlashCount = uint.MaxValue,
                 Timeout = 0
             };
-            _ = NativeFunctions.FlashWindowEx(flashWInfo);
+            _ = NativeFunctions.FlashWindowEx(ref flashWInfo);
 
             await Task.Delay(flashDuration);
 
@@ -165,7 +165,7 @@ private async void FlashTaskbarIconIfNotForeground(TimeSpan flashDuration)
                 FlashCount = 0,
                 Timeout = 0
             };
-            _ = NativeFunctions.FlashWindowEx(stopFlashWInfo);
+            _ = NativeFunctions.FlashWindowEx(ref stopFlashWInfo);
         }
 
         private class FfmpegDownloadProgress : IProgress<ProgressInfo>

diff --git a/TwitchDownloaderWPF/Services/NativeFunctions.cs b/TwitchDownloaderWPF/Services/NativeFunctions.cs
@@ -15,7 +15,7 @@ public static unsafe class NativeFunctions
 
         [DllImport("user32.dll", EntryPoint = "FlashWindowEx", PreserveSig = true)]
         [return: MarshalAs(UnmanagedType.Bool)]
-        public static extern bool FlashWindowEx(FlashWInfo info);
+        public static extern bool FlashWindowEx([In] ref FlashWInfo info);
 
         // https://learn.microsoft.com/en-us/windows/win32/api/winuser/ns-winuser-flashwinfo
         [StructLayout(LayoutKind.Sequential)]