Add FFmpeg command verbose log (#1248)

* Verbose log FFmpeg working dir and args * Use FFmpeg path when logging
lay295 · Nov 10, 2024 · b105ed8 · b105ed8
1 parent defdc91
commit b105ed8
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/TwitchDownloaderCore/ChatRenderer.cs b/TwitchDownloaderCore/ChatRenderer.cs
@@ -390,6 +390,8 @@ private FfmpegProcess GetFfmpegProcess(FileInfo fileInfo)
                 }
             };
 
+            _progress.LogVerbose($"Running \"{renderOptions.FfmpegPath}\" in \"{process.StartInfo.WorkingDirectory}\" with args: {process.StartInfo.Arguments}");
+
             process.Start();
             process.BeginErrorReadLine();
             process.BeginOutputReadLine();

diff --git a/TwitchDownloaderCore/VideoDownloader.cs b/TwitchDownloaderCore/VideoDownloader.cs
@@ -386,6 +386,8 @@ private async Task<int> RunFfmpegVideoCopy(string tempFolder, FileInfo outputFil
                 HandleFfmpegOutput(e.Data, encodingTimeRegex, videoLength);
             };
 
+            _progress.LogVerbose($"Running \"{downloadOptions.FfmpegPath}\" in \"{process.StartInfo.WorkingDirectory}\" with args: {CombineArguments(process.StartInfo.ArgumentList)}");
+
             process.Start();
             process.BeginErrorReadLine();
 
@@ -401,6 +403,17 @@ private async Task<int> RunFfmpegVideoCopy(string tempFolder, FileInfo outputFil
             } while (!process.HasExited || !logQueue.IsEmpty);
 
             return process.ExitCode;
+
+            static string CombineArguments(IEnumerable<string> args)
+            {
+                return string.Join(' ', args.Select(x =>
+                {
+                    if (!x.StartsWith('"') && !x.StartsWith('\'') && x.Contains(' '))
+                        return $"\"{x}\"";
+
+                    return x;
+                }));
+            }
         }
 
         private void HandleFfmpegOutput(string output, Regex encodingTimeRegex, TimeSpan videoLength)