Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppImage icon is broken in basic setup #11214

Closed
zach-delong opened this issue Oct 15, 2024 · 8 comments
Closed

AppImage icon is broken in basic setup #11214

zach-delong opened this issue Oct 15, 2024 · 8 comments
Labels
bug It's a bug stale An issue that hasn't been active for a while...

Comments

@zach-delong
Copy link

Operating system

Linux

Joplin version

3.0.15

Desktop version info

Joplin 3.0.15 (prod, linux)

Client ID: 64c113d6fca244a28e7ddd65fb041570
Sync Version: 3
Profile Version: 47
Keychain Supported: No

Revision: 598677b

Backup: 1.4.1

Extra information about my system to help debugging:
Screenshot from 2024-10-15 15-08-40

Current behaviour

  • I "installed" the Joplin AppImage linked here
    Screenshot from 2024-10-15 15-03-25
  • I allows AppImageLauncher to "integrate" the app and set up the icon for it.
  • In my dock, I see an error icon
    Screenshot from 2024-10-15 15-04-51
  • If I navigate to the AppImage in /home/me/Applications the AppImage doesn't have an icon
    Screenshot from 2024-10-15 15-05-53
  • If I alt+enter to see properties I do see an icon correctly, so it's definitely in there somewhere
    Screenshot from 2024-10-15 15-06-38

Expected behaviour

I expect the icons to appear everywhere and not just in the AppImage's properties.

Logs

I don't think there are any logs relating to this, though I'll follow any instructions to grab anything.

@zach-delong zach-delong added the bug It's a bug label Oct 15, 2024
@zach-delong
Copy link
Author

Update: I reinstalled using the suggested script and I still have the same broken icon on my dock. 🤔

@quack-o
Copy link

quack-o commented Oct 25, 2024

problem is that its app_id has '/' character in its name, appid is whats used to pick icon for a window, and it is causing issues

@zach-delong
Copy link
Author

I did some more debugging and noticed that my desktop (also running Fedora 40) doesn't have this issue, so I kept digging in. I have the icon at ~/.local/share/icons/hicolor/512x512/apps/joplin.png and in my desktop icon file I have

[Desktop Entry]
Encoding=UTF-8
Name=Joplin
Comment=Joplin for Desktop
Exec=env APPIMAGELAUNCHER_DISABLE=TRUE "/home/zachery/.joplin/Joplin.AppImage"  %u
Icon=joplin
StartupWMClass=Joplin
Type=Application
Categories=Office;
MimeType=x-scheme-handler/joplin;
X-GNOME-SingleWindow=true // should be removed eventually as it was upstream to be an XDG specification
SingleMainWindow=true

So the icon and the image appear to exist in the right places, but I'm not sure why they aren't connecting yet.

problem is that its app_id has '/' character in its name, appid is whats used to pick icon for a window, and it is causing issues

I would expect this is probably why the appimage itself doesn't have the right icon, but the "installer script" that I fell back to when the appimage didn't behave as expected seems to my untrained eye to account for this by setting up its own .desktop file that manually specifies.

@quack-o
Copy link

quack-o commented Oct 29, 2024

gnome uses startup-wm class to find icon i think, hence its correct in fedora, but other wms, specially wlroots, they use app_id only, hence the issue in them

@zach-delong
Copy link
Author

zach-delong commented Oct 29, 2024

hence its correct in fedora

Both of my computers are Fedora, but one of them (my laptop) is showing the broken icon, which is strange. I was just using my laptop as normal and installed something (wine) and the icon magically fixed itself. I am not sure why the icon would just fix itself during install but not during reboot, but apparently something got shaken loose...

Copy link
Contributor

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

@github-actions github-actions bot added the stale An issue that hasn't been active for a while... label Nov 28, 2024
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, feel free to create a new issue with up-to-date information.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 5, 2024
@zach-delong
Copy link
Author

I have tried to reproduce this again and haven't been able to. I think the issue is either resolved by a recent patch or it's harder to reproduce than I realized. Either way, good to go for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug stale An issue that hasn't been active for a while...
Projects
None yet
Development

No branches or pull requests

2 participants