Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate source timecode frames #70

Open
latenitefilms opened this issue Mar 15, 2024 · 0 comments
Open

Duplicate source timecode frames #70

latenitefilms opened this issue Mar 15, 2024 · 0 comments
Assignees
@latenitefilms
Labels
bug Something isn't working

Comments

@latenitefilms
Copy link
Owner

As reported in #68, there's a bug where the source timecode is being calculated incorrectly - i.e. frame 4 will be correct, but frame 5 will be the same value as frame 5.

Here's an example FCPXML:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE fcpxml>

<fcpxml version="1.11">
    <resources>
        <format id="r1" frameDuration="100/2500s" width="1800" height="1080" colorSpace="1-1-1 (Rec. 709)"/>
        <asset id="r2" name="B022_B030_0223UF_001" uid="E4DD3DA35BE4CC6F70E2915342E5C467" start="1578252676/25025s" duration="1757756/25025s" hasVideo="1" format="r3" hasAudio="1" videoSources="1" audioSources="1" audioChannels="2" audioRate="48000">
            <media-rep kind="original-media" sig="E4DD3DA35BE4CC6F70E2915342E5C467" src="file:///Volumes/Crucial%202TB%20696554916/240222%20XTANTOS/FOOTAGE_/D5/D5%20CAM%20B/Camara_B_Dia_05_X_Tantos/B022_B030_0223UF_001.mov"/>
        </asset>
        <format id="r3" name="FFVideoFormat1080p25" frameDuration="100/2500s" width="1920" height="1080" colorSpace="1-1-1 (Rec. 709)"/>
        <effect id="r4" name="Timecode" uid=".../Effects.localized/Basics.localized/Timecode.localized/Timecode.moef"/>
    </resources>
    <project name="XTANTOS_LARGA_240313_TC_TESTS - REPEAT FRAMES 1" uid="F08E1372-6EB3-488A-9FC8-2E90B29B84F4" modDate="2024-03-15 16:32:42 +1100">
        <sequence format="r1" duration="3103100/2502500s" tcStart="0s" tcFormat="NDF" audioLayout="stereo" audioRate="48k">
            <note>XTANTOS_GNRC 41 ✅ 1</note>
            <spine>
                <asset-clip ref="r2" offset="0s" name="B022_B030_0223UF_001" start="1579850272/25025s" duration="3103100/2502500s" format="r3" tcFormat="NDF" audioRole="dialogue" videoRole="CAM_B">
                    <adjust-conform type="fill"/>
                    <adjust-volume amount="-96dB"/>
                    <audio-channel-source srcCh="1, 2" role="dialogue.dialogue-1"/>
                </asset-clip>
            </spine>
        </sequence>
    </project>
</fcpxml>

Frame 4 (0.16sec) is correctly displayed as 17:32:11:01 / 1578276 frames / 63131.04 seconds.
Frame 5 (0.2sec) is incorrectly displayed with the same value.

Looking at the JSON cache:

  "4\/25s" : {
    "Above Primary Storyline - Lane 1 - Keywords + Notes (Horizontal)" : "",
    "Above Primary Storyline - Lane 1 - Blend Mode" : "",
    "Above Primary Storyline - Lane 1 - Source Name" : "🔥 Metaburner",
    "Above Primary Storyline - Lane 1 - Video - Source Timecode (HH:MM:SS:FF)" : "",
    "Primary Storyline - Video Role" : "CAM_B",
    "Above Primary Storyline - Lane 1 - Tripod Mode" : "",
    "Above Primary Storyline - Lane 1 - Smoothing" : "",
    "allVideoRoles" : "  CAM_B",
    "Primary Storyline - Audio - Source Filename" : "B022_B030_0223UF_001.mov",
    "allAudioRoles" : " dialogue",
    "Primary Storyline - Smoothing" : "",
    "Above Primary Storyline - Lane 1 - Markers (Vertical)" : "",
    "Primary Storyline - Audio - Source Timecode (HH:MM:SS:FF)" : "17:32:11:01",
    "Above Primary Storyline - Lane 1 - Spatial Conform" : "",
    "Primary Storyline - Keywords + Notes (Horizontal)" : "",
    "Above Primary Storyline - Lane 1 - Note" : "",
    "Primary Storyline - Opacity" : "100.00% (static)",
    "Primary Storyline - Video - Source Full Path" : "\/Volumes\/Crucial 2TB 696554916\/240222 XTANTOS\/FOOTAGE_\/D5\/D5 CAM B\/Camara_B_Dia_05_X_Tantos\/B022_B030_0223UF_001.mov",
    "Above Primary Storyline - Lane 1 - Markers + Notes (Horizontal)" : "",
    "Above Primary Storyline - Lane 1 - Source Start Timecode" : "01:00:00:00",
    "Primary Storyline - Keyword Notes (Vertical)" : "",
    "Above Primary Storyline - Lane 1 - Keyword Notes (Horizontal)" : "",
    "Primary Storyline - Marker Notes (Horizontal)" : "",
    "Above Primary Storyline - Lane 1 - Audio - Source Timecode (HH:MM:SS:FF)" : "",
    "Primary Storyline - Scale" : "x=100.00, y=100.00 (static)",
    "Above Primary Storyline - Lane 1 - Opacity" : "100.00% (static)",
    "Primary Storyline - Source Start Timecode" : "17:32:10:22",
    "Above Primary Storyline - Lane 1 - Audio Roles (Vertical)" : "",
    "Above Primary Storyline - Lane 1 - Keywords + Notes (Vertical)" : "",
    "Primary Storyline - Markers (Vertical)" : "Video SOURCE TC repeats frames in Metaburner",
    "Primary Storyline - Markers + Notes (Vertical)" : "Video SOURCE TC repeats frames in Metaburner",
    "Above Primary Storyline - Lane 1 - Translation Smooth" : "",
    "Primary Storyline - Video - Source Filename" : "B022_B030_0223UF_001.mov",
    "Above Primary Storyline - Lane 1 - Markers + Marker Type + Notes (Vertical)" : "",
    "Above Primary Storyline - Lane 1 - Source Timecode Format" : "⚠️ Unknown",
    "Above Primary Storyline - Lane 1 - Audio Roles (Horizontal)" : "",
    "Above Primary Storyline - Lane 1 - Video Effects (Vertical)" : "No Effects",
    "Above Primary Storyline - Lane 1 - Markers (Horizontal)" : "",
    "Primary Storyline - Video Effects (Vertical)" : "Timecode",
    "Primary Storyline - Position" : "x=0.0, y=0.0 (static)",
    "Above Primary Storyline - Lane 1 - Rotation Smooth" : "",
    "Primary Storyline - Video - Source Timecode (HH:MM:SS:FF)" : "17:32:11:01",
    "Primary Storyline - Stabilization Type" : "",
    "Above Primary Storyline - Lane 1 - Audio - Source Filename (No Extension)" : "",
    "Above Primary Storyline - Lane 1 - Markers + Marker Type (Horizontal)" : "",
    "Primary Storyline - Markers + Marker Type + Notes (Horizontal)" : "Video SOURCE TC repeats frames in Metaburner",
    "Primary Storyline - Audio - Source Full Path" : "\/Volumes\/Crucial 2TB 696554916\/240222 XTANTOS\/FOOTAGE_\/D5\/D5 CAM B\/Camara_B_Dia_05_X_Tantos\/B022_B030_0223UF_001.mov",
    "Above Primary Storyline - Lane 1 - Audio Roles & Subroles (Horizontal)" : "",
    "Primary Storyline - Marker Notes (Vertical)" : "",
    "Above Primary Storyline - Lane 1 - Markers + Notes (Vertical)" : "",
    "Primary Storyline - Rotation" : "0° (static)",
    "Primary Storyline - Markers (Horizontal)" : "Video SOURCE TC repeats frames in Metaburner",
    "Primary Storyline - Audio Roles (Vertical)" : "dialogue",
    "Above Primary Storyline - Lane 1 - Audio - Source Full Path" : "",
    "Primary Storyline - Custom Metadata Field - com.apple.proapps.studio.metadataDeinterlaceType" : "0",
    "Above Primary Storyline - Lane 1 - Audio - Source Timecode (Frames)" : "",
    "Above Primary Storyline - Lane 1 - Scale Smooth" : "",
    "Primary Storyline - Audio Effects (Vertical)" : "No Effects",
    "Primary Storyline - Audio Effects (Horizontal)" : "No Effects",
    "Above Primary Storyline - Lane 1 - Position" : "",
    "Primary Storyline - Source Duration" : "00:00:01:06",
    "Primary Storyline - Audio - Source Filename (No Extension)" : "B022_B030_0223UF_001",
    "Primary Storyline - Markers + Marker Type + Notes (Vertical)" : "Video SOURCE TC repeats frames in Metaburner",
    "Primary Storyline - Source Frame Rate" : "25",
    "Primary Storyline - Markers + Marker Type (Vertical)" : "Video SOURCE TC repeats frames in Metaburner",
    "Primary Storyline - Video Effects (Horizontal)" : "Timecode",
    "Primary Storyline - Audio Roles & Subroles (Horizontal)" : "Dialogue",
    "Above Primary Storyline - Lane 1 - Video - Source Timecode (Frames)" : "",
    "Primary Storyline - Custom Metadata Field - com.apple.proapps.studio.metadataFieldDominanceOverride" : "0",
    "Above Primary Storyline - Lane 1 - Keywords (Horizontal)" : "",
    "Primary Storyline - Blend Mode" : "Normal",
    "Primary Storyline - Markers + Notes (Horizontal)" : "Video SOURCE TC repeats frames in Metaburner",
    "Primary Storyline - Tripod Mode" : "",
    "Above Primary Storyline - Lane 1 - Markers + Marker Type (Vertical)" : "",
    "Primary Storyline - Keywords (Vertical)" : "",
    "Primary Storyline - Scale Smooth" : "",
    "Above Primary Storyline - Lane 1 - Video - Source Filename" : "",
    "Primary Storyline - Source Name" : "B022_B030_0223UF_001",
    "Above Primary Storyline - Lane 1 - Marker Notes (Vertical)" : "",
    "Above Primary Storyline - Lane 1 - Audio - Source Filename" : "",
    "Primary Storyline - Source Timecode Format" : "NDF",
    "Primary Storyline - Custom Metadata Field - com.apple.proapps.studio.reel" : "B022_B030_0223UF",
    "Primary Storyline - Keywords + Notes (Vertical)" : "",
    "Primary Storyline - Keyword Notes (Horizontal)" : "",
    "Above Primary Storyline - Lane 1 - Keywords (Vertical)" : "",
    "Above Primary Storyline - Lane 1 - Source Frame Rate" : "60",
    "Primary Storyline - Rotation Smooth" : "",
    "Above Primary Storyline - Lane 1 - Keyword Notes (Vertical)" : "",
    "Primary Storyline - Translation Smooth" : "",
    "Primary Storyline - Custom Metadata Field - com.apple.proapps.studio.scene" : "D5.4 \/ BUS int \/ vuelta PROTAS \/ B-ROLL",
    "Primary Storyline - Keywords (Horizontal)" : "",
    "Above Primary Storyline - Lane 1 - Stabilization Type" : "",
    "Primary Storyline - Custom Metadata Field - com.apple.proapps.studio.angle" : "2",
    "Primary Storyline - Audio Roles (Horizontal)" : "dialogue",
    "Above Primary Storyline - Lane 1 - Audio Effects (Horizontal)" : "No Effects",
    "Primary Storyline - Video - Source Timecode (Seconds)" : "0.00",
    "Primary Storyline - Audio - Source Timecode (Frames)" : "1578276",
    "Primary Storyline - Audio Roles & Subroles (Vertical)" : "Dialogue",
    "Above Primary Storyline - Lane 1 - Audio - Source Timecode (Seconds)" : "",
    "Above Primary Storyline - Lane 1 - Video Effects (Horizontal)" : "No Effects",
    "Above Primary Storyline - Lane 1 - Marker Notes (Horizontal)" : "",
    "Above Primary Storyline - Lane 1 - Scale" : "",
    "Above Primary Storyline - Lane 1 - Source Duration" : "00:10:00:00",
    "Above Primary Storyline - Lane 1 - Audio Effects (Vertical)" : "No Effects",
    "Primary Storyline - Audio - Source Timecode (Seconds)" : "0.00",
    "Above Primary Storyline - Lane 1 - Video - Source Timecode (Seconds)" : "",
    "Above Primary Storyline - Lane 1 - Video - Source Filename (No Extension)" : "",
    "Above Primary Storyline - Lane 1 - Rotation" : "",
    "Above Primary Storyline - Lane 1 - Video Role" : "",
    "Above Primary Storyline - Lane 1 - Markers + Marker Type + Notes (Horizontal)" : "",
    "Above Primary Storyline - Lane 1 - Video - Source Full Path" : "",
    "Primary Storyline - Video - Source Filename (No Extension)" : "B022_B030_0223UF_001",
    "Primary Storyline - Video - Source Timecode (Frames)" : "1578276",
    "Primary Storyline - Spatial Conform" : "Fill",
    "Above Primary Storyline - Lane 1 - Audio Roles & Subroles (Vertical)" : "",
    "Primary Storyline - Note" : "",
    "Primary Storyline - Markers + Marker Type (Horizontal)" : "Video SOURCE TC repeats frames in Metaburner"
  },
  "1\/5s" : {
  "Above Primary Storyline - Lane 1 - Source Frame Rate" : "60",
  "Primary Storyline - Video - Source Timecode (HH:MM:SS:FF)" : "17:32:11:01",
  "Primary Storyline - Source Timecode Format" : "NDF",
  "Above Primary Storyline - Lane 1 - Source Name" : "🔥 Metaburner",
  "Above Primary Storyline - Lane 1 - Spatial Conform" : "",
  "Primary Storyline - Video - Source Filename" : "B022_B030_0223UF_001.mov",
  "Above Primary Storyline - Lane 1 - Audio Roles & Subroles (Horizontal)" : "",
  "Primary Storyline - Source Duration" : "00:00:01:06",
  "Primary Storyline - Video Effects (Horizontal)" : "Timecode",
  "Above Primary Storyline - Lane 1 - Markers + Marker Type + Notes (Horizontal)" : "",
  "Primary Storyline - Keywords + Notes (Horizontal)" : "",
  "Primary Storyline - Note" : "",
  "Primary Storyline - Audio - Source Filename (No Extension)" : "B022_B030_0223UF_001",
  "Primary Storyline - Audio Roles & Subroles (Vertical)" : "Dialogue",
  "Primary Storyline - Source Frame Rate" : "25",
  "Primary Storyline - Video - Source Filename (No Extension)" : "B022_B030_0223UF_001",
  "Primary Storyline - Audio Roles (Vertical)" : "dialogue",
  "Primary Storyline - Video Role" : "CAM_B",
  "Above Primary Storyline - Lane 1 - Keywords + Notes (Horizontal)" : "",
  "Above Primary Storyline - Lane 1 - Audio - Source Timecode (HH:MM:SS:FF)" : "",
  "Primary Storyline - Markers + Notes (Horizontal)" : "Video SOURCE TC repeats frames in Metaburner",
  "Primary Storyline - Spatial Conform" : "Fill",
  "Above Primary Storyline - Lane 1 - Keywords (Horizontal)" : "",
  "Primary Storyline - Keywords (Vertical)" : "",
  "Primary Storyline - Custom Metadata Field - com.apple.proapps.studio.metadataDeinterlaceType" : "0",
  "Primary Storyline - Keywords + Notes (Vertical)" : "",
  "Primary Storyline - Audio Roles (Horizontal)" : "dialogue",
  "Primary Storyline - Stabilization Type" : "",
  "Primary Storyline - Position" : "x=0.0, y=0.0 (static)",
  "Above Primary Storyline - Lane 1 - Markers (Vertical)" : "",
  "Above Primary Storyline - Lane 1 - Audio - Source Full Path" : "",
  "Above Primary Storyline - Lane 1 - Video - Source Filename (No Extension)" : "",
  "Primary Storyline - Markers + Marker Type (Horizontal)" : "Video SOURCE TC repeats frames in Metaburner",
  "Primary Storyline - Marker Notes (Vertical)" : "",
  "Primary Storyline - Source Name" : "B022_B030_0223UF_001",
  "Primary Storyline - Video - Source Timecode (Frames)" : "1578276",
  "allAudioRoles" : " dialogue",
  "Above Primary Storyline - Lane 1 - Rotation" : "",
  "Primary Storyline - Audio Roles & Subroles (Horizontal)" : "Dialogue",
  "Above Primary Storyline - Lane 1 - Keywords (Vertical)" : "",
  "Primary Storyline - Markers + Notes (Vertical)" : "Video SOURCE TC repeats frames in Metaburner",
  "Above Primary Storyline - Lane 1 - Translation Smooth" : "",
  "Above Primary Storyline - Lane 1 - Audio Roles (Horizontal)" : "",
  "Above Primary Storyline - Lane 1 - Audio Effects (Horizontal)" : "No Effects",
  "Primary Storyline - Scale" : "x=100.00, y=100.00 (static)",
  "Primary Storyline - Translation Smooth" : "",
  "Above Primary Storyline - Lane 1 - Audio - Source Filename (No Extension)" : "",
  "Above Primary Storyline - Lane 1 - Video - Source Timecode (Seconds)" : "",
  "Primary Storyline - Keywords (Horizontal)" : "",
  "Above Primary Storyline - Lane 1 - Scale" : "",
  "Primary Storyline - Video - Source Full Path" : "\/Volumes\/Crucial 2TB 696554916\/240222 XTANTOS\/FOOTAGE_\/D5\/D5 CAM B\/Camara_B_Dia_05_X_Tantos\/B022_B030_0223UF_001.mov",
  "Above Primary Storyline - Lane 1 - Smoothing" : "",
  "Above Primary Storyline - Lane 1 - Keywords + Notes (Vertical)" : "",
  "Primary Storyline - Markers + Marker Type + Notes (Vertical)" : "Video SOURCE TC repeats frames in Metaburner",
  "Primary Storyline - Rotation" : "0° (static)",
  "Primary Storyline - Keyword Notes (Horizontal)" : "",
  "Above Primary Storyline - Lane 1 - Markers + Marker Type (Horizontal)" : "",
  "Above Primary Storyline - Lane 1 - Video Role" : "",
  "Above Primary Storyline - Lane 1 - Scale Smooth" : "",
  "Primary Storyline - Custom Metadata Field - com.apple.proapps.studio.angle" : "2",
  "Above Primary Storyline - Lane 1 - Video - Source Filename" : "",
  "Above Primary Storyline - Lane 1 - Source Timecode Format" : "⚠️ Unknown",
  "Above Primary Storyline - Lane 1 - Audio - Source Filename" : "",
  "Primary Storyline - Audio - Source Timecode (Frames)" : "1578276",
  "Above Primary Storyline - Lane 1 - Audio Effects (Vertical)" : "No Effects",
  "Above Primary Storyline - Lane 1 - Stabilization Type" : "",
  "Above Primary Storyline - Lane 1 - Marker Notes (Vertical)" : "",
  "Above Primary Storyline - Lane 1 - Video Effects (Vertical)" : "No Effects",
  "Primary Storyline - Markers (Vertical)" : "Video SOURCE TC repeats frames in Metaburner",
  "Above Primary Storyline - Lane 1 - Keyword Notes (Horizontal)" : "",
  "Primary Storyline - Marker Notes (Horizontal)" : "",
  "Above Primary Storyline - Lane 1 - Markers + Notes (Vertical)" : "",
  "Primary Storyline - Smoothing" : "",
  "Primary Storyline - Video - Source Timecode (Seconds)" : "0.00",
  "Primary Storyline - Video Effects (Vertical)" : "Timecode",
  "Primary Storyline - Markers + Marker Type (Vertical)" : "Video SOURCE TC repeats frames in Metaburner",
  "Above Primary Storyline - Lane 1 - Audio - Source Timecode (Seconds)" : "",
  "Primary Storyline - Audio - Source Full Path" : "\/Volumes\/Crucial 2TB 696554916\/240222 XTANTOS\/FOOTAGE_\/D5\/D5 CAM B\/Camara_B_Dia_05_X_Tantos\/B022_B030_0223UF_001.mov",
  "Above Primary Storyline - Lane 1 - Video - Source Full Path" : "",
  "Above Primary Storyline - Lane 1 - Markers + Marker Type + Notes (Vertical)" : "",
  "Above Primary Storyline - Lane 1 - Source Duration" : "00:10:00:00",
  "Primary Storyline - Rotation Smooth" : "",
  "Primary Storyline - Keyword Notes (Vertical)" : "",
  "Above Primary Storyline - Lane 1 - Markers + Marker Type (Vertical)" : "",
  "Above Primary Storyline - Lane 1 - Blend Mode" : "",
  "Primary Storyline - Audio - Source Timecode (Seconds)" : "0.00",
  "Above Primary Storyline - Lane 1 - Opacity" : "100.00% (static)",
  "Above Primary Storyline - Lane 1 - Keyword Notes (Vertical)" : "",
  "Primary Storyline - Source Start Timecode" : "17:32:10:22",
  "Primary Storyline - Audio Effects (Horizontal)" : "No Effects",
  "Primary Storyline - Markers (Horizontal)" : "Video SOURCE TC repeats frames in Metaburner",
  "Primary Storyline - Audio Effects (Vertical)" : "No Effects",
  "Primary Storyline - Blend Mode" : "Normal",
  "Primary Storyline - Custom Metadata Field - com.apple.proapps.studio.scene" : "D5.4 \/ BUS int \/ vuelta PROTAS \/ B-ROLL",
  "allVideoRoles" : "  CAM_B",
  "Above Primary Storyline - Lane 1 - Audio Roles & Subroles (Vertical)" : "",
  "Above Primary Storyline - Lane 1 - Note" : "",
  "Above Primary Storyline - Lane 1 - Video Effects (Horizontal)" : "No Effects",
  "Primary Storyline - Tripod Mode" : "",
  "Above Primary Storyline - Lane 1 - Audio Roles (Vertical)" : "",
  "Primary Storyline - Custom Metadata Field - com.apple.proapps.studio.reel" : "B022_B030_0223UF",
  "Primary Storyline - Scale Smooth" : "",
  "Above Primary Storyline - Lane 1 - Markers (Horizontal)" : "",
  "Primary Storyline - Audio - Source Timecode (HH:MM:SS:FF)" : "17:32:11:01",
  "Above Primary Storyline - Lane 1 - Source Start Timecode" : "01:00:00:00",
  "Above Primary Storyline - Lane 1 - Tripod Mode" : "",
  "Above Primary Storyline - Lane 1 - Rotation Smooth" : "",
  "Above Primary Storyline - Lane 1 - Marker Notes (Horizontal)" : "",
  "Above Primary Storyline - Lane 1 - Video - Source Timecode (Frames)" : "",
  "Above Primary Storyline - Lane 1 - Audio - Source Timecode (Frames)" : "",
  "Primary Storyline - Custom Metadata Field - com.apple.proapps.studio.metadataFieldDominanceOverride" : "0",
  "Primary Storyline - Audio - Source Filename" : "B022_B030_0223UF_001.mov",
  "Above Primary Storyline - Lane 1 - Markers + Notes (Horizontal)" : "",
  "Above Primary Storyline - Lane 1 - Position" : "",
  "Above Primary Storyline - Lane 1 - Video - Source Timecode (HH:MM:SS:FF)" : "",
  "Primary Storyline - Markers + Marker Type + Notes (Horizontal)" : "Video SOURCE TC repeats frames in Metaburner",
  "Primary Storyline - Opacity" : "100.00% (static)"
},

Something is going wrong in the asset-clip source calculations.
@latenitefilms latenitefilms added the bug Something isn't working label Mar 15, 2024
@latenitefilms latenitefilms self-assigned this Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@latenitefilms latenitefilms

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@latenitefilms