-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confusing behavior between interesting exit code and interesting regexp, at least with treereduce-rust #195
Comments
Hey, thanks for the report! I agree that this is confusing.
I agree that this would be very clear, but it would unfortunately make the CLI a bit more verbose, and less analogous with that of Halfempty. Perhaps instead, we could have each interestingness condition be an |
Yea, this would work as well. "Default interesting exit code is 0 unless there are other criterias". |
Consider options
--interesting-exit-code
and--interesting-stderr
.Right now the reduction is considered to be interesting when either condition matches:
treereduce/crates/treereduce/src/check.rs
Line 228 in 15e338b
Suppose I'm tracking a specific compiler crash, I would pass
--interesting-stderr my-error
and don't specify any interesting exit code. This leaves it at a default value of 0 andtreereduce-rust
quickly reduces the example to empty file - "code 0 is interesting" according to default command line options.Next attempt is me passing an expected exit code along with interesting stderr, but this can lead to minimization for some other compiler crash.
As a result to track a specific crash I need to pass
--interesting-stderr my-error
as well as--interesting-exit-code 12345
- some exit code that doesn't match.There's several ways to solve it, least confusing would be to get rid of default code of 0 and ask user to specify at least one interesting criteria - exit code or regexp.
The text was updated successfully, but these errors were encountered: