Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Langchain Python Dataset run has null trace I/O #1919

Open
nimbusaeta opened this issue Apr 30, 2024 · 2 comments
Open

bug: Langchain Python Dataset run has null trace I/O #1919

nimbusaeta opened this issue Apr 30, 2024 · 2 comments
Assignees
Labels

Comments

@nimbusaeta
Copy link

Describe the bug

In the VUI, in the Dataset run view, the inputs of each view appear as null, but in the Dataset Item view, the input is populated with the expected text.

To reproduce

The run was created following the Datasets Cookbook (the Langchain application part).

Additional information

No response

@marcklingen
Copy link
Member

Thanks for creating this issue. We'll try to push a fix soon.

More context:

  • item.get_langchain_handler() creates a trace under the hood
  • if the handler is then passed to a langchain agent/chain, it does not update the trace (this is generally the desired behavior as multiple runs could be grouped into the same trace).

@marcklingen marcklingen changed the title bug: Dataset runs show null input although it's not null bug: Langchain Python Dataset run has null trace I/O Apr 30, 2024
@marcklingen marcklingen assigned marcklingen and unassigned hassiebp May 7, 2024
@pckim93
Copy link

pckim93 commented Jun 10, 2024

Is this still an issue? I'm running into this as well (with some paths adjusted for privacy):

.../eval.py 
Traceback (most recent call last):
  File ".../eval.py", line 191, in <module>
    main()
  File ".../eval.py", line 100, in main
    handler = item.get_langchain_handler(
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File ".venv/lib/python3.11/site-packages/langfuse/client.py", line 2553, in get_langchain_handler
    self.link(
  File ".venv/lib/python3.11/site-packages/langfuse/client.py", line 2518, in link
    self.langfuse.client.dataset_run_items.create(
  File ".venv/lib/python3.11/site-packages/langfuse/api/resources/dataset_run_items/client.py", line 127, in create
    raise NotFoundError(pydantic_v1.parse_obj_as(typing.Any, _response.json()))  # type: ignore
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
langfuse.api.resources.commons.errors.not_found_error.NotFoundError: status_code: 404, body: {'message': 'Trace not found'}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants