Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in feedback.ts file Implement Retry Logic for Slack Webhook Calls #847

Open
wenayy opened this issue Oct 9, 2024 · 2 comments
Open

in feedback.ts file Implement Retry Logic for Slack Webhook Calls #847

wenayy opened this issue Oct 9, 2024 · 2 comments
Assignees

Comments

@wenayy
Copy link

wenayy commented Oct 9, 2024

The current implementation of the webhook handler sends feedback data to the Slack webhook using a simple fetch request. While this works under normal circumstances, it lacks resilience in the face of temporary issues such as network instability, timeouts, or Slack service outages. If the webhook call fails due to any temporary issue (e.g., network errors, rate-limiting by Slack, server unavailability), the request will fail permanently without retries, resulting in a poor user experience.

Objective: We should implement a retry mechanism that will attempt to resend the feedback data to Slack a certain number of times before giving up. This will help in ensuring that the request doesn't fail immediately due to temporary issues, improving the robustness of the system.

@marcklingen
Copy link
Member

sounds good, open for contributions on this. alternatively, you could also handle the error state and display an error to try again

@wenayy
Copy link
Author

wenayy commented Oct 9, 2024

assign me this i will try to work on each aspect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants