-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example with touch... not working? #47
Comments
I haven't seen that; for me it was working until I updated to the latest dev. Currently (with latest dev; which will be released with ESPHome 2023.12), the touchscreen component cannot even be compiled :-( Working on that, but no ETA yet |
The base touchscreen component was changed, and all external touchscreen components need some reworking. I've got it to compile, but the touch coordinates are completely bonkers. Will keep looking. |
Not looking good... I've got it working if I don't set the display rotation, but as soon as I set rotation 90 or 270, the y coordinates get halved (i.e. from 0-90 instead of 0-170). On the plus side of things, there is a PR on the official ESPHome repo (esphome/esphome#5941) that adds touchscreen functionality for exactly this same touch controller. And it's a PR by someone who was involved on the touch/display discussions that are causing the problem now. So there is a chance, that official support for this touch screen is coming into ESPHome core "soon" |
Thank you for your answer. PS: Fingers crossed for the official support "soon". |
To make the "t-display-s3 touchscreen" work, I had to do many changes in the code, that I haven't pushed yet. The PR I mentioned above works "out-of-the-box", if the display rotation is 0 (i.e. not set).
If I change the display rotation, then the touch coordinates are just wrong 😢 |
Could you share the full code (for me to try it)? |
@inakiarredondo I've created a PR (#50) that should fix the compilation issues with 2023.12 Whether this also fixes the "Failed to communicate" issue you originally mentioned, I cannot tell, since I'm not seeing this (nor was seeing it before). But it is probably worth a try (it is actually a must, if you upgraded to ESPHome 2023.12.0 or later) |
Now, once updated to ESPHome 2023 12.3, I get this warning
|
Yes, with 2023.12.0 there were some changes done to the touchscreen base component, that in turn required changes to the implementations. That's what #50 should fix, but somehow it does not get through CI, so we cannot merge it. You might want to take a look at that PR; if I am not mistaken I wrote a comment on how to use that (you need to add |
@inakiarredondo The needed PR has been merged now. Can you try without the |
Sorry for the delay. Yes, I've tried without the @Branch part, with ESPHome 2023.12.5 and also with 2023.12.7 ...but the "Failed to communicate!" keeps arising on the logs. Iñaki |
Hello, I have the same problem with this error : "[lilygo_tdisplay_s3.touchscreen:082]: Failed to communicate!" when I touch the screen with ESPHome 2024.4.1. |
I finally solved my problem. |
Has anyone managed to get the example-with-touch to work? (with Lilygo T-Display-S3 Touch version)
Logs show this message: "[E][lilygo_tdisplay_s3.touchscreen:069]: Failed to communicate!" (8 times in a row, each time I touch the screen)
Any advice? Thank you.
The text was updated successfully, but these errors were encountered: