-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The ClientEngine.start() promise is not resolved #124
Comments
that would be an excellent PR. |
For anyone looking for a workaround, you can hack around it by doing the following:
This works because Hacky? Yes. But, it does cause this comment was edited to make the workaround more reliable |
Can we please change the code of ClientEngine.start so that it resolves once it's ready?
I was extremely confused that this just wouldn't work:
Or this:
It seems like a very bad idea to not resolve the promise immediately. (Not to mention that rejecting with undefined makes debugging a nightmare.)
I'd be willing to make a PR, but I wanted to discuss this first.
The text was updated successfully, but these errors were encountered: