-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FreeRTOSConfig.h should be a separate header #2
Comments
The reason I did not do it for the other ARM Cortex-M was I have not spent much time thinking about the correct definitions for the other ones. But I agree it is not elegant. Another approach would be to add a new CMake variable like And add this definition to the existing RTOS/FreeRTOS/include/FreeRTOSConfig.h.in like that:
What do you think? |
That seems like a good solution to me. |
First, thanks a lot for working on this project. It's so helpful to have a CMake-based buildsystem for the ARM/CMSIS/FreeRTOS! I haven't worked much with other stacks but it's cool to know that I could use this if I wanted to.
The FreeRTOS application doesn't compile for the Arm Cortex M7 target out of the box because
configMAX_SYSCALL_INTERRUPT_PRIORITY
doesn't get set. I noticed that this gets set in board.h for the ARMCM4 target but not the M7. The way this is done in the ST Cube framework is by the application providing a separate FreeRTOSConfig.h header. What do you think of this pattern? It seems cleaner to me. For now I just throw the definition of the missing settings into board.h to be consistent with the other target as a workaround.The text was updated successfully, but these errors were encountered: