Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#284: Improve error texts for arrays of objects #285

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dhardtke
Copy link
Contributor

@dhardtke dhardtke commented Jun 9, 2023

I think it is not helpful to shorten arrays or objects and always better to print shortened objects.

I also fixed a typo in toHaveSubset's negatedReason.

Fixes #284

@changeset-bot
Copy link

changeset-bot bot commented Jun 9, 2023

⚠️ No Changeset found

Latest commit: 3e09150

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jun 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
earl-docs ✅ Ready (Inspect) Visit Preview Jun 9, 2023 0:47am

@xndlnk
Copy link

xndlnk commented Jul 10, 2023

Is there any progress here? PR is open since 1 month. I'd also like to see this improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expect.toInclude with expect.subset() does not generate helpful error texts
2 participants