When Phone is in 12-hours mode events become 24hours long

[graldij]

Hello,
In the process of testing my app using the KVKCalendar, I noticed that whenever the iPhone has the 12-hours layout (e.g. 15.15 is 3.15 pm), the length of the events displayed is wrong: instead of the actual length they becomr 24-hours long (see screenshot). I tried to set style.timeSystem = TimeHourSystem.twentyFour but nothing has changed.
Is this a bug? Or are there some other style-settings useful to solve the problem?

Thanks!

[kvyatkovskys]

🤔 try to set style.timeSystem = TimeHourSystem.twelve

[graldij]

🤔 try to set style.timeSystem = TimeHourSystem.twelve

Nothing changes: correctly displayed for 24-hours system and with that strange behaviour for the 12-hours system

[graldij]

    var i: Int=0
    for course in courses {

        let isoDateStart = course.startEvent
        let dateStartFormatter = ISO8601DateFormatter()

        let isoDateEnd = course.endEvent
        let dateEndFormatter = ISO8601DateFormatter()
        var event = Event(ID: "\(i)")

        event.start = dateStartFormatter.date(from: isoDateStart)!
        event.end = dateEndFormatter.date(from: isoDateEnd)!
        event.text = course.name

        events.append(event)

        i=i+1
    }

That's the way I am creating the events, fyi

[kvyatkovskys]

could you print event.start & event.end, pls? to check data 🤔

[graldij]

For the following code

var i: Int=0
for course in courses {

    let isoDateStart = course.startEvent
    let dateStartFormatter = ISO8601DateFormatter()

    let isoDateEnd = course.endEven
    let dateEndFormatter = ISO8601DateFormatter()
    var event = Event(ID: "\(i)")
            

    event.start = dateStartFormatter.date(from: isoDateStart)!
    event.end = dateEndFormatter.date(from: isoDateEnd)!
    event.text = course.name

    print(event.start)
    print(event.end)
            
    print(dateStartFormatter.date(from: isoDateStart)!)
    print(dateEndFormatter.date(from: isoDateEnd)!)
            
    events.append(event)

    i=i+1
}

I get these outputs for 12-hours system:

2021-03-05 11:30:00 AM +0000
2021-03-05 1:30:00 PM +0000
2021-03-05 11:30:00 AM +0000
2021-03-05 1:30:00 PM +0000

And these for the correct 24-hours system:

2021-03-05 11:30:00 +0000
2021-03-05 13:30:00 +0000
2021-03-05 11:30:00 +0000
2021-03-05 13:30:00 +0000

[kvyatkovskys]

I'll check this but I think the problem is related to ISO8601DateFormatter()

[graldij]

Okay, thanks! Please let me know if you find something!

[kvyatkovskys]

Could not reproduce, works fine for me 🤔

[graldij]

well, that's strange. Did you change the entire iPhone hour-system, right?

[fatenumber25]

I fixed it in TimelineView.swift as below and solved it.

Before

let timeLabelFormatter: DateFormatter = {
    let formatter = DateFormatter()
    formatter.dateFormat = "HH:mm"
    return formatter
}()

After

let timeLabelFormatter: DateFormatter = {
    let formatter = DateFormatter()
    formatter.dateFormat = "HH:mm"
    formatter.calendar = Calendar(identifier: .gregorian)
    formatter.locale = Locale(identifier: "en_US_POSIX")
    return formatter
}()

[kvyatkovskys]

Could you create a PR with your fix, pls?