Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TTL value owerwritten #10

Open
punqbund opened this issue Dec 29, 2021 · 6 comments
Open

TTL value owerwritten #10

punqbund opened this issue Dec 29, 2021 · 6 comments
Assignees
Labels
invalid This doesn't seem right

Comments

@punqbund
Copy link
Contributor

After the DDNS update, the TTL value was set to 0, regardless of the default TTL value.

Zonefile entry before DDNS update:

; A Records
<my record>		IN	A	<my ip address>

After DDNS update:

; A Records
<my record>	0	IN	A	<my ip address>
@kutzilla kutzilla added the invalid This doesn't seem right label Dec 30, 2021
@kutzilla kutzilla self-assigned this Dec 30, 2021
@kutzilla
Copy link
Owner

The DDNS sets the TTL value to 0. I agree with you that it should use the default TTL value. Im going to add an environment variable to set it manually. If not set, it uses the default value of Hetzner. Therefore it shouldn't effect the zonefile. What do you think about that?

@punqbund
Copy link
Contributor Author

This sounds good. If the environment variable with appropriate value is provided, it should set it, if the user does not set the environment variable, the TTL should not be set at all.

kutzilla added a commit that referenced this issue Jan 1, 2022
kutzilla added a commit that referenced this issue Jan 9, 2022
@kutzilla
Copy link
Owner

kutzilla commented Mar 7, 2022

The environment variable is now included in v2.0

@kutzilla
Copy link
Owner

kutzilla commented Mar 8, 2022

Nevermind. I got to fix it. I'm going to respond if it's working

kutzilla added a commit that referenced this issue Mar 28, 2022
kutzilla added a commit that referenced this issue May 23, 2022
@kutzilla
Copy link
Owner

kutzilla commented Jun 8, 2022

Could you try it again? Just put out version 2.1, which includes a new implementation to read the provided config. Now the TTL value should be factored in.

@punqbund
Copy link
Contributor Author

punqbund commented Jun 9, 2022

@kutzilla I tested it today. Now, if no ttl value provided, the default value will be written into the zone file:
@ 86400 IN A xxx.xxx.xxx.xxx

It is a working solution. But actually I would expect that it would not set the ttl value, if not provided, and and the result would be like
@ IN A xxx.xxx.xxx.xxx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants