Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove/Rename un-namespaced macros #45

Open
klange opened this issue Dec 22, 2023 · 0 comments
Open

Remove/Rename un-namespaced macros #45

klange opened this issue Dec 22, 2023 · 0 comments

Comments

@klange
Copy link
Collaborator

klange commented Dec 22, 2023

We expose a lot of macros which are not prefixed with KRK_ or krk_. To provide a clean API, these should be renamed.

  • *_VAL macros for creating value cells. These should be renamed to look like function calls and use the correct type names, eg. krk_new_int or something similar.
  • AS_* for extracting from value cells and objects. These should at least be prefixed, and the value ones should be updated to use the right names. krk_as_?
  • IS_* type checking convenience macros. Same as above.
  • Various old-style argument checking macros like METHOD_TAKES_*/FUNCTION_TAKES_*.
  • Binding macros, like BIND_METHOD, and the related MAKE_CLASS macro (which doesn't seem to be used?)

While we're at it, removing the old-style KRK_FUNC/KRK_METHOD macros would be worthwhile. All of the code I have on hand has been converted to the new-style KRK_Function/KRK_Method macros.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant