Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use badge id in badge export to get attendee by type (if possible) #164

Open
faebiedev opened this issue Nov 13, 2023 · 0 comments
Open

Don't use badge id in badge export to get attendee by type (if possible) #164

faebiedev opened this issue Nov 13, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@faebiedev
Copy link
Contributor

faebiedev commented Nov 13, 2023 •
edited
Loading

The number of VIP badge types changed for 2023, and when exporting, I exported some specialty badges with vip badges due to this check below in BadgeExportService

case "Vip":
    List<Attendee> vip1 = attendeeRepository.findAllByBadgeType(6);
    List<Attendee> vip2 = attendeeRepository.findAllByBadgeType(7);
    List<Attendee> vip3 = attendeeRepository.findAllByBadgeType(8);

if there's a better way to find vip badges other than checking badge id then should swap over to that (or at least document that this should be updated if the number of badge types change)
@faebiedev faebiedev added the bug Something isn't working label Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@faebiedev