Skip to content
This repository has been archived by the owner on Nov 26, 2019. It is now read-only.

Home view - replace badge table #115

Open
jashort opened this issue Dec 29, 2017 · 2 comments
Open

Home view - replace badge table #115

jashort opened this issue Dec 29, 2017 · 2 comments
Assignees

Comments

@jashort
Copy link
Member

jashort commented Dec 29, 2017

For performance, the Table on the Home view could be a static table in a Label instead of an actual Vaadin Table/Grid.

@jashort
Copy link
Member Author

jashort commented Jan 3, 2018

If you look at HomeView.java, you'll see that it uses a Grid (think table) to display the list of badge types. The Grid control has a lot of features, which unfortunately makes it slower than just straight HTML in a Label control.

Switch out the Grid passTypesTable for a Label, and populate the label with the same information in a HTML table. You can see an example of this is AttendeeReportView.java (the report's view) and AttendeeReportPresenter.java (the presenter)

It would probably make more sense (architecturally) to build the HTML in the view.

You can keep the table simple/ugly if it makes things easier. You can add CSS classes to the styles.scss file, but it's kind of a pain unless you've done it a few times.

@PaulDStrong
Copy link

Sounds good. I feel relatively comfortable with HTML and CSS, so this was probably a good assignment for me to start with. I don't know my schedule for this week, but I am hoping to be able to do a little at work and my wife and I are trying to figure out a night a week for me to look into professional development.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants