Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to disable retries #10248

Closed
lahabana opened this issue May 16, 2024 · 0 comments · Fixed by #10250
Closed

Add ability to disable retries #10248

lahabana opened this issue May 16, 2024 · 0 comments · Fixed by #10250
Assignees
@lahabana
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Milestone
2.8.x

Comments

@lahabana
Copy link
Contributor

Description

When overriding a default you may want to disable retries altogether.
@lahabana lahabana added triage/pending This issue will be looked at on the next triage meeting kind/feature New feature labels May 16, 2024
lahabana added a commit to lahabana/kuma that referenced this issue May 16, 2024
@lahabana
feat(MeshRetry): allow setting numRetries to 0 to disable retries
eadcb15 
Currently if you have any retry policy inherited from anywhere you
wouldn't be able to remove the retries in a more specific policy.

This enables users to set `{grpc,http}.numRetries = 0` in a more
specific policy and remove the retry filter completely.

It also disallows `tcp.maxConnectAttempt = 0` which would create an
invalid envoy configuration.

fix kumahq#10248

Signed-off-by: Charly Molter <[email protected]>
@lahabana lahabana mentioned this issue May 16, 2024
Merged
5 tasks
@lahabana lahabana added this to the 2.8.x milestone May 16, 2024
@lahabana lahabana self-assigned this May 16, 2024
@jakubdyszkiewicz jakubdyszkiewicz added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels May 20, 2024
lahabana added a commit that referenced this issue May 22, 2024
@lahabana
feat(MeshRetry): allow setting numRetries to 0 to disable retries (#1…
e0221c6 
…0250)

Currently if you have any retry policy inherited from anywhere you
wouldn't be able to remove the retries in a more specific policy.

This enables users to set `{grpc,http}.numRetries = 0` in a more
specific policy and remove the retry filter completely.

It also disallows `tcp.maxConnectAttempt = 0` which would create an
invalid envoy configuration.

fix #10248

Signed-off-by: Charly Molter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lahabana lahabana

Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
2.8.x
Development

Successfully merging a pull request may close this issue.

feat(MeshRetry): allow setting numRetries to 0 to disable retries lahabana/kuma
2 participants
@lahabana @jakubdyszkiewicz