Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove botkube.io/disable annotation and adjustannotation and labels constrains #1009

Open
Tracked by #840
mszostok opened this issue Mar 7, 2023 · 0 comments
Open
Tracked by #840

Remove botkube.io/disable annotation and adjustannotation and labels constrains #1009

mszostok opened this issue Mar 7, 2023 · 0 comments
Labels
enhancement New feature or request needs-triage Relates to issues that should be refined

Comments

@mszostok
Copy link
Contributor

mszostok commented Mar 7, 2023 •
edited

Description

Remove botkube.io/disable annotation and adjust annotation and labels constrains on k8s source plugin to allow setting the include and exclude properties similar to what we have for others constrains.

AC

  • remove object annotation checker
  • update annotation and labels constrains
  • update documentation
  • update e2e tests
@mszostok mszostok mentioned this issue Mar 7, 2023
Closed
11 tasks
@mszostok mszostok added this to the v0.21.0 milestone Mar 7, 2023
@mszostok mszostok changed the title Remove botkube.io/disable annotations and add support for annotation and labels constrains on k8s source to allow setting up include and exclude. Remove botkube.io/disable annotation and adjustannotation and labels constrains Mar 7, 2023
@mszostok mszostok added enhancement New feature or request needs-triage Relates to issues that should be refined labels Mar 7, 2023
@pkosiec pkosiec modified the milestones: v1.2.0, v1.1.0 Apr 4, 2023
@mszostok mszostok removed this from the v1.1.0 milestone Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request needs-triage Relates to issues that should be refined
Projects
Botkube
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pkosiec @mszostok