-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check new colours work OK with white background #1385
Comments
I suppose a major scope of improvement for this lies in replacing the yellow text we have. It'd be better to instead have a contrast neutral colour which looks good on both black and white, all the other existing colours look good for both the backgrounds as far as I can tell (other than yellow). |
Is it practical to detect "light mode" and "dark mode" and use a different colour throughout? |
We could do that. The only thing I have in mind is, what would the probable output look like on a white background? It would be a bummer if we refactor everything and realize it looks bad on a white background regardless :) |
Overview
https://twitter.com/Didicodes/status/1699084012050850047/photo/2
The text was updated successfully, but these errors were encountered: