Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a PR Template for Localization Branches. #46393

Closed
3 tasks
AbdelatifAitBara opened this issue May 15, 2024 · 13 comments
Closed
3 tasks

Adding a PR Template for Localization Branches. #46393

AbdelatifAitBara opened this issue May 15, 2024 · 13 comments
Labels
area/localization General issues or PRs related to localization kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@AbdelatifAitBara
Copy link
Contributor

AbdelatifAitBara commented May 15, 2024

This is a Feature Request

What would you like to be added

I'm part of the Arabic localization team, and I'd like to add a pull_request_template.md file to our branch dev-1.29-ar.1.
If other localization teams are amenable to the following template, it would be beneficial to include it in their respective branches as well.

Why is this needed

This will have many advantages; I'll mention a few below:

  • Efficient Reviews.
  • Traceability.
  • Visual Context.
  • Standardization.

Comments

This is the PR Template:

Description
[Provide a clear and concise description of the changes made in this PR.]

Related Issue
[Mention the issue number or link to the related issue that this PR addresses.]

Preview of Edited Page(s)
[Provide a link to a preview of the edited page(s) for easier review.]

Checklist

  • I have tested the changes locally and they are working as expected.
  • I have followed the coding style guidelines.
  • I have squashed my commits into a single commit with a clear commit message.

Additional Information
[Provide any additional information or context that might be helpful for the reviewers and approvers.]

@AbdelatifAitBara AbdelatifAitBara added the kind/feature Categorizes issue or PR as related to a new feature. label May 15, 2024
@k8s-ci-robot k8s-ci-robot added the language/ar Issues or PRs related to Arabic language label May 15, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

SIG Docs takes a lead on issue triage for this website, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. language/fr Issues or PRs related to French language language/it Issues or PRs related to Italian language language/de Issues or PRs related to German language language/es Issues or PRs related to Spanish language language/hi Issues or PRs related to Hindi language language/id Issues or PRs related to Indonesian language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/pl Issues or PRs related to Polish language language/ru Issues or PRs related to Russian language language/uk Issues or PRs related to Ukrainian language labels May 15, 2024
@k8s-ci-robot
Copy link
Contributor

@AbdelatifAitBara: The label(s) language/pt-br, language/zh-cn cannot be applied, because the repository doesn't have them.

In response to this:

/language it
/language de
/language es
/language hi
/language id
/language ja
/language ko
/language pl
/language pt-br
/language ru
/language uk
/language vi
/language zh-cn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added language/vi Issues or PRs related to Vietnamese language language/bn Issues or PRs related to Bengali language language/pt Issues or PRs related to Portuguese language labels May 15, 2024
@k8s-ci-robot
Copy link
Contributor

@AbdelatifAitBara: The label(s) language/cn cannot be applied, because the repository doesn't have them.

In response to this:

/language bn
/language pt
/language cn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the language/zh Issues or PRs related to Chinese language label May 15, 2024
@sftim
Copy link
Contributor

sftim commented May 15, 2024

If you add a pull request template, that localization branch would then not be mergeable into main. I don't recommend it.

We could change the main pull request template to mention that extra detail is needed for localization work, and you could then cherry-pick that change. I think that'd be OK.

@sftim
Copy link
Contributor

sftim commented May 15, 2024

Here's the existing template. What's not right about it?

@sftim
Copy link
Contributor

sftim commented May 15, 2024

/remove-language ar
/remove-language bn
/remove-language de
/remove-language es
/remove-language fr
/remove-language hi
/remove-language id
/remove-language it
/remove-language ja
/remove-language ko
/remove-language pl
/remove-language pt
/remove-language ru
/remove-language uk
/remove-language vi
/remove-language zh
/area localization

@k8s-ci-robot k8s-ci-robot added area/localization General issues or PRs related to localization and removed language/ar Issues or PRs related to Arabic language language/bn Issues or PRs related to Bengali language language/de Issues or PRs related to German language language/es Issues or PRs related to Spanish language language/fr Issues or PRs related to French language labels May 15, 2024
@k8s-ci-robot k8s-ci-robot removed language/hi Issues or PRs related to Hindi language language/id Issues or PRs related to Indonesian language language/it Issues or PRs related to Italian language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/pl Issues or PRs related to Polish language language/pt Issues or PRs related to Portuguese language language/ru Issues or PRs related to Russian language language/uk Issues or PRs related to Ukrainian language language/vi Issues or PRs related to Vietnamese language language/zh Issues or PRs related to Chinese language labels May 15, 2024
@AbdelatifAitBara
Copy link
Contributor Author

Sure, we'll be happy to use that one and maybe adding some extra details as you said.
The problem we are facing now is that when we try to open a PR on our branch dev-1.29-ar.1, we don't get any template, even the one you mentioned.

@sftim
Copy link
Contributor

sftim commented May 16, 2024

Do you see something like this when you try to open a PR?

Screenshot

That's what I saw when I tried.

If not, I wonder why not?

@AbdelatifAitBara
Copy link
Contributor Author

Now yes, perhaps when I opened my first PR, I did not notice it. I apologize for that.

So do you think that we could add some more details to this one? As :

Related Issue
[Mention the issue number or link to the related issue that this PR addresses.]

Preview of Edited Page(s)
[Provide a link to a preview of the edited page(s) for easier review.]

Checklist

  • I have tested the changes locally and they are working as expected.
  • I have followed the coding style guidelines.
  • I have squashed my commits into a single commit with a clear commit message.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 14, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 13, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

@k8s-ci-robot k8s-ci-robot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 13, 2024
@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/localization General issues or PRs related to localization kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

4 participants