-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a PR Template for Localization Branches. #46393
Comments
This issue is currently awaiting triage. SIG Docs takes a lead on issue triage for this website, but any Kubernetes member can accept issues by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@AbdelatifAitBara: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@AbdelatifAitBara: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
If you add a pull request template, that localization branch would then not be mergeable into main. I don't recommend it. We could change the main pull request template to mention that extra detail is needed for localization work, and you could then cherry-pick that change. I think that'd be OK. |
Here's the existing template. What's not right about it? |
/remove-language ar |
Sure, we'll be happy to use that one and maybe adding some extra details as you said. |
Now yes, perhaps when I opened my first PR, I did not notice it. I apologize for that. So do you think that we could add some more details to this one? As : Related Issue Preview of Edited Page(s) Checklist
|
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close not-planned |
@k8s-triage-robot: Closing this issue, marking it as "Not Planned". In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is a Feature Request
What would you like to be added
I'm part of the Arabic localization team, and I'd like to add a
pull_request_template.md
file to our branchdev-1.29-ar.1
.If other localization teams are amenable to the following template, it would be beneficial to include it in their respective branches as well.
Why is this needed
This will have many advantages; I'll mention a few below:
Comments
This is the PR Template:
Description
[Provide a clear and concise description of the changes made in this PR.]
Related Issue
[Mention the issue number or link to the related issue that this PR addresses.]
Preview of Edited Page(s)
[Provide a link to a preview of the edited page(s) for easier review.]
Checklist
Additional Information
[Provide any additional information or context that might be helpful for the reviewers and approvers.]
The text was updated successfully, but these errors were encountered: