Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the typo in non - template pod acquisitions #46320

Closed
wants to merge 1 commit into from

Conversation

thisisharrsh
Copy link
Contributor

Fixes : #46319

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 11, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign divya-mohan0209 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels May 11, 2024
Copy link

netlify bot commented May 11, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit ffd7e60
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/663f213fec0ff900080054bb
😎 Deploy Preview https://deploy-preview-46320--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Placing a hold on this PR since the issue and the PR introduce trivial edits that don't improve the quality of the documentation. Request approvers/reviewers to unhold only if sufficient justification has been provided regarding the improvement of quality.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2024
@divya-mohan0209
Copy link
Contributor

Latest update on the issue:

Please refer to this issue comment. The issue suggests a trivial edit and several other subjective edits that don't significantly improve the quality of the Kubernetes documentation, IMO.

Note to other wranglers and approvers: If you feel that there is a significant change in the readability/quality of documentation, please feel free to go ahead and remove the hold on the PR + accept the triage on the issue.

@sftim
Copy link
Contributor

sftim commented Jul 30, 2024

/close

Issue is closed. However, we'd welcome a start-to-finish editorial review (as in, read through the Markdown source and propose fixes) of the existing content about ReplicaSet.

@k8s-ci-robot
Copy link
Contributor

@sftim: Closed this PR.

In response to this:

/close

Issue is closed. However, we'd welcome a start-to-finish editorial review (as in, read through the Markdown source and propose fixes) of the existing content about ReplicaSet.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A Minor Typo in Website for Replicaset in docs/concepts/workloads/controllers/replicaset
4 participants