Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PRs into Postsubmit Refs #31964

Closed
rcrozean opened this issue Feb 12, 2024 · 5 comments
Closed

Add PRs into Postsubmit Refs #31964

rcrozean opened this issue Feb 12, 2024 · 5 comments
Labels
area/prow Issues or PRs related to prow kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/testing Categorizes an issue or PR as relevant to SIG Testing.

Comments

@rcrozean
Copy link
Contributor

What would you like to be added:
Github API allows for connecting commits to pull requests.. I would like to add PRs associated to the base_sha in the Postsubmit refs.

refs:
...
  pulls:
  - author: <user>
    number: <pr #>
    title: <pr title>
...

Why is this needed:
This could add a simple way to connect Postsubmits to Presubmits and chaining jobs without integrating the pipeline tooling.

PS: Happy to work on this, but wanted to confirm this direction was of interest before beginning

@rcrozean rcrozean added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 12, 2024
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Feb 12, 2024
@rcrozean
Copy link
Contributor Author

/sig prow
/area prow

@k8s-ci-robot
Copy link
Contributor

@rcrozean: The label(s) sig/prow cannot be applied, because the repository doesn't have them.

In response to this:

/sig prow
/area prow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the area/prow Issues or PRs related to prow label Feb 12, 2024
@rcrozean
Copy link
Contributor Author

/sig testing

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 12, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 13, 2024
@BenTheElder
Copy link
Member

Unfortunately it doesn't seem like there's been a response / interest.

Prow is now split out at https://github.com/kubernetes-sigs/prow/ and future discussions should be held there for better visibility.

I don't think Kubernetes has a use case for this and we have very limited maintainer bandwidth for prow etc.

Also personally pointing out: commits can be in multiple pull requests, I suspect this would lead to buggy edge cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/prow Issues or PRs related to prow kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Development

No branches or pull requests

4 participants