Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"kops version --server" should assume current context by default #16586

Open
shapirus opened this issue May 21, 2024 · 4 comments
Open

"kops version --server" should assume current context by default #16586

shapirus opened this issue May 21, 2024 · 4 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@shapirus
Copy link
Contributor

shapirus commented May 21, 2024

/kind feature

1. Describe IN DETAIL the feature/behavior/change you would like to see.
Current behavior:

$ kops version --server 
Client version: 1.28.4 (git-v1.28.4)
Last applied server version: No cluster selected

Proposed behavior:

$ kops version --server
Client version: 1.28.4 (git-v1.28.4)
Last applied server version: 1.28.4

Unless an explicit --name <name> argument is provided, it won't work.

2. Feel free to provide a design supporting your feature request.
Assume current context by default.

(and maybe kops version should also show server version by default? that's questionable though, as it will introduce the delay caused by querying the server.)

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label May 21, 2024
@hakman
Copy link
Member

hakman commented May 21, 2024

Try kops version --server. 😁

@shapirus
Copy link
Contributor Author

Try kops version --server. 😁

Lol yes, shame on me. Well, almost:

Last applied server version: No cluster selected

it doesn't use current context as default value and requires --name <name> to be specified explicitly.

@hakman
Copy link
Member

hakman commented May 21, 2024

it doesn't use current context as default value and requires --name <name> to be specified explicitly.

Not sure why this happens, probably not hard to fix.

@shapirus shapirus changed the title "kops version" should also show kops server version "kops version --server" should assume current context by default May 21, 2024
@shapirus
Copy link
Contributor Author

shapirus commented May 21, 2024

it doesn't use current context as default value and requires --name <name> to be specified explicitly.

Not sure why this happens, probably not hard to fix.

I went ahead and edited the title and first post to reflect this, now that I discovered the --server option, to avoid wasting bytes and opening a new issue :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants