Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New update to SIG Storage 2023 report #7822

Merged

Conversation

xing-yang
Copy link
Contributor

@xing-yang xing-yang commented Apr 16, 2024

Which issue(s) this PR fixes:

Fixes #7782

cc @saad-ali @msau42 @jsafrane

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/annual-reports Issues or PRs related to the annual reports approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Apr 16, 2024
@xing-yang
Copy link
Contributor Author

/assign @pacoxu

@MadhavJivrajani
Copy link
Contributor

/hold
just to prevent accidental merge

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2024
@jsafrane
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2024
3. Did you have community-wide updates in 2023 (e.g. KubeCon talks)?

<!--
Examples include links to email, slides, or recordings.
-->
- KubeCon NA update 2023: https://www.youtube.com/watch?v=spyEgGcqwFs
- KubeCon EU update 2023: https://www.youtube.com/watch?v=zZFN9KMs5sI
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a virtual one.

@xing-yang
Copy link
Contributor Author

@MadhavJivrajani We've got approval from @pacoxu. Can the "hold" be removed now? Thanks.

3. Did you have community-wide updates in 2023 (e.g. KubeCon talks)?

<!--
Examples include links to email, slides, or recordings.
-->
- KubeCon NA update 2023: https://www.youtube.com/watch?v=spyEgGcqwFs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- KubeCon NA update 2023: https://www.youtube.com/watch?v=spyEgGcqwFs
- KubeCon NA update 2023: https://www.youtube.com/watch?v=spyEgGcqwFs
- KubeCon CN update 2023: https://www.youtube.com/watch?v=SPfJrDnnprs

I think we can unhold after this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Thanks for catching that.

Copy link
Member

@saad-ali saad-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacoxu, saad-ali, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pacoxu
Copy link
Member

pacoxu commented May 23, 2024

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 23, 2024
@k8s-ci-robot k8s-ci-robot merged commit f9f1765 into kubernetes:master May 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/annual-reports Issues or PRs related to the annual reports cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2023 Annual Report: SIG Storage
6 participants