Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudflare provider rate limits cause a fatal error and pod restarts into CLBO #4434

Closed
ebachle opened this issue May 6, 2024 · 0 comments · Fixed by #4437
Closed

Cloudflare provider rate limits cause a fatal error and pod restarts into CLBO #4434

ebachle opened this issue May 6, 2024 · 0 comments · Fixed by #4437
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@ebachle
Copy link
Contributor

ebachle commented May 6, 2024

What happened: External DNS for Cloudflare often enters CrashLoopBackOff when it hits a rate limit. Since this was merged #3009 with the v0.13.5 release this has been occurring. We caught it on an upgrade to 0.14.1

What you expected to happen: Rate limit errors should be handled as the new SoftError type to prevent bailing and restarting.

How to reproduce it (as minimally and precisely as possible):

  • Run a version of external-dns >= 0.13.5
  • Use up the rate limit of Cloudflare API calls (or mock this)
  • Have external-dns running through a loop
  • It will then exit and bail.

Anything else we need to know?:

I'm willing to attempt to fix this, though my golang isn't super

Environment:

  • External-DNS version (use external-dns --version): 0.14.1
  • DNS provider: cloudflare
  • Others:
@ebachle ebachle added the kind/bug Categorizes issue or PR as related to a bug. label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant