Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to v0.29.X k8s versions #499

Open
cprivitere opened this issue Jan 9, 2024 · 3 comments
Open

Bump to v0.29.X k8s versions #499

cprivitere opened this issue Jan 9, 2024 · 3 comments
Labels
triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@cprivitere
Copy link
Member

No description provided.

@displague displague changed the title Bump to v0.28.X k8s versions Bump to v0.29.X k8s versions Feb 2, 2024
@displague
Copy link
Member

displague commented Feb 2, 2024

Dependabot related PRs that have failing tests:

Running [/home/runner/golangci-lint-1.55.2-linux-amd64/golangci-lint run --out-format=github-actions] in [] ...
  Error: cannot infer S (/home/runner/go/pkg/mod/golang.org/x/[email protected]/slices/slices.go:116:1) (typecheck)
  Error: cannot infer S (/home/runner/go/pkg/mod/golang.org/x/[email protected][42](https://github.com/kubernetes-sigs/cloud-provider-equinix-metal/actions/runs/7568454455/job/20609692952?pr=501#step:4:44)d/slices/sort.go:17:1) (typecheck)
  Error: cannot infer S (/home/runner/go/pkg/mod/golang.org/x/[email protected]/slices/slices.go:351:1) (typecheck)
  Error: cannot infer S (/home/runner/go/pkg/mod/golang.org/x/[email protected]/slices/slices.go:219:1) (typecheck)
  
  Error: issues found

perhaps related to one of these (or GolangCI not catching up to the regression fix in 1.21 for 1.22):

@displague
Copy link
Member

displague commented May 2, 2024

#535 is another dependabot attempt to address this (moving to 1.30.0).

I tacked on the following (updating other k8s.io packages and x/exp) but the cannot infer S linter is still tripping.
439db1f
f3930f6
4f129e2
8ca4a9a

Attempting to bump golangci-lint from 1.55.2 to 1.57.2 as an additional measure (12788ad)

@cprivitere
Copy link
Member Author

/triage accepted

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants