Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding rulebook_url also affects external alerts #40

Open
serathius opened this issue Jun 25, 2018 · 4 comments
Open

Adding rulebook_url also affects external alerts #40

serathius opened this issue Jun 25, 2018 · 4 comments

Comments

@serathius
Copy link
Contributor

Automatic rulebook_url generation runs as mixin without any condition.
So when vendoring kubernetes-mixin, my own alerts are also affected by this.

@tomwilkie
Copy link
Member

Hi @serathius! Thanks for the report. Can confirm this is not the intention - I was under the impression the merge ordering would fix this but looks like we've got the same problem. I'll give it some thought.

@serathius
Copy link
Contributor Author

Your right, my lack of jsonnet knowledge here. Order is important here.
Maybe example in README would help?

@tomwilkie
Copy link
Member

Sorry my comment was not clear: I was under the impression the merge ordering was important, but we have the same problem, and we're merging in the "right" order. So it looks like merge ordering isn't important. I need to do some more investigation.

Copy link

This issue has not had any activity in the past 30 days, so the
stale label has been added to it.

  • The stale label will be removed if there is new activity
  • The issue will be closed in 7 days if there is no new activity
  • Add the keepalive label to exempt this issue from the stale check action

Thank you for your contributions!

@github-actions github-actions bot added stale and removed stale labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants